include nc 13 in travis test and adjust cases accordingly#427
Merged
Conversation
marcelklehr
reviewed
Jan 15, 2018
| <&= escapeHTML(title == '' ? encodeURI(url) : title ) &> | ||
| </a> | ||
| <span class="bookmark_edit bookmark_edit_btn"> | ||
| <img class="svg" src="<?php print_unescaped(OCP\image_path("", "actions/rename.svg")); ?>" title="<?php p($l->t('Edit')); ?>"> |
required for Nextcloud 14/master where it was removed
blizzz
force-pushed
the
update-test-matrix
branch
from
72ac02f to
4b3c3b1
Compare
Member
Author
|
fixed with recent commit :) UPDATE ah, not realized #426 was a PR… |
marcelklehr
approved these changes
Jan 15, 2018
| title="<?php p($l->t('Delete')); ?>"> | ||
| </span> | ||
| <span class="tag_edit"> | ||
| <img class="svg" src="<?php print_unescaped(OCP\image_path("", "actions/rename.svg")); ?>" |
Member
There was a problem hiding this comment.
Is this a good idea? I have no clue how the templating works, though. From this I assume, it's a separate scope, which would give this a lgtm verdict.
Member
Author
There was a problem hiding this comment.
yeah, he methods are defined in lib/private/legacy/template/functions.php and also called by the Template class. These short forms are also used in server and shipped apps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to solve #425
let's see whether i caught everything