Avoid auth redirection when activity restarted

[surinder-tsys]

Steps to reproduce:
User should not be logged in

1. If any activity sets enableAccountHandling to false.
2. Take app to background
3. Now bring back app to foreground
4. OnRestart from base activity will trigger and will launch AuthenticatorActivity which overrides the previous activity for which enableAccountHandling is false.

• Tests written, or not not needed

[ZetaTom]

@surinder-tsys Unfortunately, I'm not sure what problem this pull request is supposed to fix. Could you please clarify what behaviour you were expecting and what you were observing instead?

[surinder-tsys]

@ZetaTom If user is on FirstRunActivity and if the activity gets restarted (pressing home screen and again opening app from Recents) that time it will redirects to AuthenticatorActivity, because enableAccountHandling flag check is not applied in onRestart function.

[ZetaTom]

I've since been able to construct a scenario where this function is called in the required context. Unfortunately, I can't see any obvious change in the behaviour of the app and haven't been able to reproduce the problem described.

Since enableAccountHandling is checked in other lifecycle related functions, such as onResume(), I can't see why it shouldn't also be checked in onRestart().

@surinder-tsys, could you check if this change is still up to date?

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	77	77
Errors	0	0

SpotBugs

Category	Base	New
Bad practice	26	26
Correctness	72	72
Dodgy code	367	367
Experimental	2	2
Internationalization	9	9
Malicious code vulnerability	2	2
Multithreaded correctness	9	9
Performance	58	58
Security	18	18
Total	563	563

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/11818.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

[surinder-tsys]

No longer required as this has been addressed in #13902.