Avoid search collapse after page refresh#11522
Merged
tobiasKaminsky merged 2 commits intonextcloud:masterfrom Aug 30, 2023
Merged
Avoid search collapse after page refresh#11522tobiasKaminsky merged 2 commits intonextcloud:masterfrom
tobiasKaminsky merged 2 commits intonextcloud:masterfrom
Conversation
Member
|
From my test this does not solve it, as after refresh is finished entire OCFileList is being redrawn and thus search collapses. |
Collaborator
Author
Hi @tobiasKaminsky |
Collaborator
Author
Fixed and PR updated. Please check. |
Collaborator
|
master-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/8340-IT-master-11-02 |
surinder-tsys
force-pushed
the
nmc/1943-avoidSearchCollapse
branch
from
4a802ba to
d3df435
Compare
1 task
surinder-tsys
force-pushed
the
nmc/1943-avoidSearchCollapse
branch
from
d3df435 to
ca6f966
Compare
ZetaTom
approved these changes
Jul 25, 2023
ZetaTom
reviewed
Jul 25, 2023
app/src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java
Show resolved
Hide resolved
surinder-tsys
force-pushed
the
nmc/1943-avoidSearchCollapse
branch
2 times, most recently
from
c442bfc to
c6a7775
Compare
surinder-tsys
force-pushed
the
nmc/1943-avoidSearchCollapse
branch
from
c6a7775 to
905222c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actions Performed
Expected Result
The search remains being properly opened.
Actual Result
The search now closes incorrectly after a short period of time.