Fix the deletion error in public links#508
Closed
sharidas wants to merge 1 commit intonextcloud:masterfrom
Closed
Conversation
When user tries to delete the files in a public link, the files don't get deleted. The tagManager gets null and there was no check to handle this. Added check for this. Signed-off-by: Sujith Haridasan <sujith.h@gmail.com>
Author
SummaryWhen user tries to delete the files inside a public link the files are not getting deleted. The permission set for the public link in this case is DescriptionThe tagManager is set to null in the stack trace. Hence I have tried to provide an array with nulls if the tagManager is null, which aligns with the function signature( function is Steps done for testing
|
Member
|
See #506 |
Member
|
Thanks for your PR anyway! 😎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When user tries to delete the files in a public
link, the files don't get deleted. The tagManager
gets null and there was no check to handle this.
Added check for this.
Signed-off-by: Sujith Haridasan sujith.h@gmail.com