refactor(types): add native parameter/return types to Data::get and APIv2Controller#2573
Open
miaulalala wants to merge 2 commits intomasterfrom
Open
refactor(types): add native parameter/return types to Data::get and APIv2Controller#2573miaulalala wants to merge 2 commits intomasterfrom
miaulalala wants to merge 2 commits intomasterfrom
Conversation
Activity
 |
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
refactor/type-safety-data-get
|
| Run status |
|
| Run duration | 03m 51s |
| Commit |
|
| Committer | Anna |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
 |
0
|
 |
0
|
 |
1
|
 |
0
|
 |
9
|
| View all changes introduced in this branch ↗︎ | |
Contributor
|
Why replace some |
…PIv2Controller - Data::get(): type the 5 previously untyped parameters (string $user, int $since, int $limit, string $sort, string $filter) and add array return type; same for the related setOffsetFromSince() helper - APIv2Controller: replace @var docblock properties with native typed properties, all with sensible defaults matching validateParameters() Three test mocks that relied on null being assignable to untyped IUser::getUID() are updated to return 'testuser' so the string property assignment passes. Signed-off-by: Anna Larch <anna@nextcloud.com> AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
miaulalala
force-pushed
the
refactor/type-safety-data-get
branch
from
065c38e to
e1c042b
Compare
Collaborator
Author
wdym? |
Contributor
I meant, in |
ShGKme
approved these changes
May 7, 2026
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
…y-data-get # Conflicts: # lib/Data.php Co-authored-by: miaulalala <7427347+miaulalala@users.noreply.github.com>
Contributor
Good catch — I've now added native type annotations to all methods in
Merge conflicts resolved in c5739ef. The conflict in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Data::get(): type the 5 previously untyped parameters (string $user,int $since,int $limit,string $sort,string $filter) and addarrayreturn type; same treatment for the privatesetOffsetFromSince()helperAPIv2Controller: replace eight/** @var type */docblock properties with native typed properties, each with a sensible default matching whatvalidateParameters()would setTest plan
composer test:unitpasses (328 tests)nullbeing assignable to untyped properties are updated to return a real string fromgetUID()🤖 AI-Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com