fix(cypress): ensure activity app is enabled and fix file list row se…#2554
Merged
miaulalala merged 1 commit intomasterfrom May 5, 2026
Merged
fix(cypress): ensure activity app is enabled and fix file list row se…#2554miaulalala merged 1 commit intomasterfrom
miaulalala merged 1 commit intomasterfrom
Conversation
f4ce782 to
c1690a3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Activity
|
||||||||||||||||||||||||||||
| Project |
Activity
|
| Branch Review |
fix/cypress-nc34-failures
|
| Run status |
|
| Run duration | 03m 25s |
| Commit |
|
| Committer | Anna |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
0
|
|
|
1
|
|
|
0
|
|
|
9
|
| View all changes introduced in this branch ↗︎ | |
252c12d to
42a4fd6
Compare
…lector for NC 34 - Add 'activity' to configureNextcloud so the app is force-enabled even if the NC 34 Docker image has it disabled after the local code is bind-mounted (which prevents the notifications settings section from rendering and leaves #app-content empty) - Drop the [data-cy-files-list] parent from getFileListRow, aligning with NC 34's own test helpers which address the same selector AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Anna Larch <anna@nextcloud.com>
42a4fd6 to
aa020f6
Compare
benjaminfrueh
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…lector for NC 34
AI-Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com