Skip to content

fix(cypress): ensure activity app is enabled and fix file list row se…#2554

Merged
miaulalala merged 1 commit intomasterfrom
fix/cypress-nc34-failures
May 5, 2026
Merged

fix(cypress): ensure activity app is enabled and fix file list row se…#2554
miaulalala merged 1 commit intomasterfrom
fix/cypress-nc34-failures

Conversation

@miaulalala
Copy link
Copy Markdown
Collaborator

…lector for NC 34

  • Add 'activity' to configureNextcloud so the app is force-enabled even if the NC 34 Docker image has it disabled after the local code is bind-mounted (which prevents the notifications settings section from rendering and leaves #app-content empty)
  • Drop the [data-cy-files-list] parent from getFileListRow, aligning with NC 34's own test helpers which address the same selector

AI-Assisted-By: Claude Sonnet 4.6 noreply@anthropic.com

@miaulalala miaulalala added this to the Nextcloud 34 milestone May 5, 2026
@miaulalala miaulalala requested a review from nickvergessen May 5, 2026 09:47
@miaulalala miaulalala self-assigned this May 5, 2026
@miaulalala miaulalala force-pushed the fix/cypress-nc34-failures branch from f4ce782 to c1690a3 Compare May 5, 2026 09:49
@miaulalala miaulalala requested review from artonge and susnux May 5, 2026 09:49
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@cypress
Copy link
Copy Markdown

cypress Bot commented May 5, 2026

Activity    Run #3660

Run Properties:  status check passed Passed #3660  •  git commit f4591cd24d: fix(cypress): ensure activity app is enabled and fix file list row se…
Project Activity
Branch Review fix/cypress-nc34-failures
Run status status check passed Passed #3660
Run duration 03m 25s
Commit git commit f4591cd24d: fix(cypress): ensure activity app is enabled and fix file list row se…
Committer Anna
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 9
View all changes introduced in this branch ↗︎

@miaulalala miaulalala force-pushed the fix/cypress-nc34-failures branch from 252c12d to 42a4fd6 Compare May 5, 2026 12:37
…lector for NC 34

- Add 'activity' to configureNextcloud so the app is force-enabled even
  if the NC 34 Docker image has it disabled after the local code is
  bind-mounted (which prevents the notifications settings section from
  rendering and leaves #app-content empty)
- Drop the [data-cy-files-list] parent from getFileListRow, aligning
  with NC 34's own test helpers which address the same selector

AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the fix/cypress-nc34-failures branch from 42a4fd6 to aa020f6 Compare May 5, 2026 14:10
@miaulalala miaulalala merged commit 16c99d6 into master May 5, 2026
53 checks passed
@miaulalala miaulalala deleted the fix/cypress-nc34-failures branch May 5, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants