Conversation
8e305ae to
6bf0e21
Compare
Currently `emit` requires two parameters even if the event type is set to `undefined`.
So `emit('foo')` will cause a Typescript error.
This fixes it by removing the second argument if the event type is set to undefined.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
6bf0e21 to
b55f4c6
Compare
skjnldsv
approved these changes
Jul 17, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
emitrequires two parameters even if the event type is set toundefined. Soemit('foo')will cause a Typescript error.This fixes it by removing the second argument if the event type is set to undefined.
common:
before:
after