Skip to content

fix(vue): allow JS Vue files#998

Merged
skjnldsv merged 1 commit intomainfrom
fix/remove-vue-block-lang
Apr 24, 2025
Merged

fix(vue): allow JS Vue files#998
skjnldsv merged 1 commit intomainfrom
fix/remove-vue-block-lang

Conversation

@ShGKme
Copy link
Copy Markdown
Contributor

@ShGKme ShGKme commented Apr 24, 2025

It isn't very useful in fully migrated to TS repositories but adds too much noise in non-migrated

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added the bug Something isn't working label Apr 24, 2025
@ShGKme ShGKme requested a review from susnux April 24, 2025 17:25
@skjnldsv skjnldsv merged commit 8103cd9 into main Apr 24, 2025
10 checks passed
@skjnldsv skjnldsv deleted the fix/remove-vue-block-lang branch April 24, 2025 18:00
Copy link
Copy Markdown
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was only enforced for Typescript config, not for JS projects!


This seems to be the wrong approach. Instead of allowing mixed stuff by default, those projects should override manually until they migrated.

The config should provide a config for best case and if you not yet reached it you probably should override until you got enough time to adjust.

Thats also why this was "warn" and not "error".

@ShGKme
Copy link
Copy Markdown
Contributor Author

ShGKme commented Apr 24, 2025

This seems to be the wrong approach. Instead of allowing mixed stuff by default, those projects should override manually until they migrated.

Making a large number of shared config users override the same config also seems to be a wrong approach of having a shared config. Shared config should work well out of the box.

The config should provide a config for best case and if you not yet reached it you probably should override until you got enough time to adjust.

What is the role of this rule in the best case? Is it to prevent adding a JS component in a repo with only TS components? It seems to be a very rare case that will be handled on review.

On the opposite, having mixed JS/TS is a quite wide case in the Nextcloud ecosystem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants