Conversation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
susnux
left a comment
There was a problem hiding this comment.
this was only enforced for Typescript config, not for JS projects!
This seems to be the wrong approach. Instead of allowing mixed stuff by default, those projects should override manually until they migrated.
The config should provide a config for best case and if you not yet reached it you probably should override until you got enough time to adjust.
Thats also why this was "warn" and not "error".
Making a large number of shared config users override the same config also seems to be a wrong approach of having a shared config. Shared config should work well out of the box.
What is the role of this rule in the best case? Is it to prevent adding a JS component in a repo with only TS components? It seems to be a very rare case that will be handled on review. On the opposite, having mixed JS/TS is a quite wide case in the Nextcloud ecosystem. |
It isn't very useful in fully migrated to TS repositories but adds too much noise in non-migrated