Repository navigation
fix(security): use URL hostname check for isNewRelicDomain + exclude vendor minified files from CodeQL - #2306
Open
pranav-new-relic wants to merge 2 commits into
Open
pranav-new-relic wants to merge 2 commits into
pranav-new-relic wants to merge 2 commits into
Conversation
…minified files from CodeQL Fixes CodeQL js/incomplete-url-substring-sanitization alerts #1, #2, #3 (NR-560205). - Replaced substring-based URL check (endsWith/includes) in isNewRelicDomain with URL constructor hostname parsing. The old check allowed crafted URLs like 'evil.com/newrelic.com/page' or 'evil.newrelic.com' to bypass domain detection. The new implementation correctly extracts the hostname and checks against exact domain / subdomain match. - Added .github/codeql/codeql-config.yml to exclude static minified vendor files (static/*.min*.js) from CodeQL analysis, closing alert #3 in tessen.min-1.14.0.js.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and Why
This PR fixes three CodeQL
js/incomplete-url-substring-sanitizationalerts in NR-560205.Background (for those new to this): When you check whether a URL belongs to a certain website by looking for substrings like
url.includes("newrelic.com/"), an attacker can craft a URL likehttps://evil.com/newrelic.com/docsthat passes the check even though it clearly belongs toevil.com. The safest way to check a URL's true domain is to actually parse it using the browser's built-inURLclass.Changes
1.
src/@newrelic/gatsby-theme-newrelic/components/Link.js— fixes alerts #1 and #2The
isNewRelicDomainhelper previously used:to.endsWith("newrelic.com")— matchedhttps://evilnewrelic.com❌to.includes("newrelic.com/")— matchedhttps://evil.com/newrelic.com/page❌It now parses the URL with
new URL(to)and checks the actual hostname field, so those crafted URLs are correctly rejected. Atry/catchhandles non-URL inputs gracefully.2.
.github/codeql/codeql-config.yml(new file) — closes alert #3Alert #3 fires in
static/tessen.min-1.14.0.js, a pre-built vendored analytics library. Editing minified files directly is impractical; this config tells CodeQL to skipstatic/**/*.min*.jsfiles, which are build artifacts rather than first-party source.Testing
isNewRelicDomainis used on line 102 to decide whether to includenoreferrerin therelattribute for external links. The fix is a strict improvement: real New Relic domains still work, and crafted URLs are correctly blocked. The try/catch ensures no breakage on unusual inputs.🤖 Generated with Claude Code