Add Traefik support alongside nginx-specific ingress annotations - #634
Open
rajeshkio wants to merge 2 commits into
Open
Add Traefik support alongside nginx-specific ingress annotations#634rajeshkio wants to merge 2 commits into
rajeshkio wants to merge 2 commits into
Conversation
- Add ServersTransport CRD template (traefik-serverstransport.yaml) to trust NeuVector's self-signed backend certs when using Traefik - Only auto-inject nginx.ingress.kubernetes.io/backend-protocol when ingressClassName is explicitly nginx, instead of always adding it (manager, controller, registry-adapter ingress templates) - Remove hardcoded nginx annotation defaults from values.yaml for controller, federation, and registry-adapter ingress blocks
Contributor
|
I have verified the PR. Traefik ingress works. |
|
I had a quick look at this PR and ask myself if it wouldn´t make more sense to add one global variable for ingresscontroller where one can say rke2-nginx-ingress or rke2-traefik and then the helm chart automatically renders the required annotations on ingress and service objects.. - what do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As nginx has been deprecated and SUSE have been moving to traefik. We should add support for traefik. The PR does the following:
to trust NeuVector's self-signed backend certs when using Traefik
ingressClassName is explicitly "nginx", instead of always adding it
(manager, controller, registry-adapter ingress templates)
controller, federation, and registry-adapter ingress blocks
values in README.md, including the Service-vs-Ingress annotation
distinction (backend scheme/transport annotations belong on the
Kubernetes Service, not the Ingress)