Leading spaces #657
Merged
Leading spaces #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julmanglano
requested review from
itdependsnetworks,
jeffkala and
qduk
as code owners
Contributor
|
Closing based on: #656 (comment) |
Collaborator
|
It looks like this currently accounts for just the first line having a leading space. Would we need to account for any top level line possibly having a space even though that isn't valid syntax? |
Co-authored-by: Ken Celenza <[email protected]>
itdependsnetworks
approved these changes
Jul 31, 2025
jeffkala
approved these changes
Jul 31, 2025
michalis1
pushed a commit
to michalis1/netutils
that referenced
this pull request
Feb 2, 2026
* Catching leading spaces at config start * spacing tests * after black * remoing wrong variable assigment * adding parametrize * reforming * black formatting * Update tests/unit/test_parser.py Co-authored-by: Ken Celenza <[email protected]> * disable=redefined-outer-name * fromatting... --------- Co-authored-by: Ken Celenza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you:
Change Notes
Added a check to handle whitespace at start of config inputs, avoiding the self.config_lines[-1] IndexError.
Added unit test(s) to cover configs with leading whitespaces.
Justification
Closes #656