Closed
Conversation
…e_1_duplicate_line
grelleum
requested review from
itdependsnetworks,
jeffkala and
qduk
as code owners
| @@ -0,0 +1,3 @@ | |||
| features = [ | |||
| {"name": "log", "ordered": True, "section": ["logging ", "no logging "]}, | |||
Contributor
There was a problem hiding this comment.
@grelleum , sorry, I realize that I did this, but can you add a feature for snmp as well? I think it was failing before with a stracktrace, and hence this test, but I think that we should now be clear about the expectation of a duplicate line.
e.g. add,
{"name": "snmp", "ordered": False, "section": ["snmp-server "]},
| """Initialization file for library.""" | ||
|
|
||
| __version__ = "0.2.2" | ||
| __version__ = "0.2.3" |
Contributor
There was a problem hiding this comment.
Thanks for pointing this out, this actually has to be fixed in a few places. You can remove this and squash, i'll update in another PR
jeffkala
approved these changes
Sep 30, 2021
Collaborator
jeffkala
left a comment
jeffkala
left a comment
There was a problem hiding this comment.
I'm good with this after the other PR review comments are addressed.
Contributor
|
Addressed in #128 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves duplicate line issue: #1
Within IOSConfigParser._update_same_line_children_configs, a conditional has been added to see if a duplicated line is indented, and therefore part of a section, before assigning a parent.