Add aerleon and capirca platform mappers #425
Conversation
scetron
requested review from
abates,
itdependsnetworks,
jeffkala and
qduk
as code owners
netutils/lib_mapper.py
Outdated
| NETMIKO_LIB_MAPPER_REVERSE = copy.deepcopy(NETMIKO_LIB_MAPPER) | ||
| NTCTEMPLATES_LIB_MAPPER_REVERSE = copy.deepcopy(NTCTEMPLATES_LIB_MAPPER) | ||
|
|
||
| NETUTILS_LIBMAPPER_MAPPER = { |
There was a problem hiding this comment.
What does this offer over "MAIN_LIB_MAPPER"?
There was a problem hiding this comment.
It appears to me that main lib mapper is more focused on the end platform, rather than the library that has a platform. I can't do MAIN_LIB_MAPPER['aerleon'] or MAIN_LIB_MAPPER['napalm'] unless I am mistaken?
There was a problem hiding this comment.
Any thoughts on this one?
There was a problem hiding this comment.
ok, should it be "netmiko": list(NETMIKO_LIB_MAPPER.keys()), then?
There was a problem hiding this comment.
Thinking about it more, it should just be
from netutils import lib_mapper
getattr(lib_mapper, f"{lib.upper()}_LIB_MAPPER")
|
Can we just list all of them so they don't trickle in as much? |
|
Do you mean list all of the platforms supported by Aerleon/Capirca? I didn't add them only because many of them don't have another name to be mapped to, which I am fine with adding as I see in some other mappers, it's the same. |
|
Yea, would be good to know what those are, even if commented out for now. |
|
@scetron let's remove the NETUTILS_LIBMAPPER_MAPPER and add to the dictionary, just to get capirca and aerleon in, we can take the topic of NETUTILS_LIBMAPPER_MAPPER to another issue. |
|
@itdependsnetworks Sounds good. Removed. @qduk Added to dev scripts and generated the new docs. |
* add capirca/aerleon lib mapper
3 participants
Added common network platforms supported by Aerleon and Capirca.