[NN20-prep] - netutils/lib_mapper.py #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pato23arg
requested review from
abates,
itdependsnetworks,
jeffkala and
qduk
as code owners
netutils/lib_mapper.py
Outdated
| _MAIN_LIB_MAPPER["huawei_vrp"] = "huawei_vrp" | ||
| _MAIN_LIB_MAPPER["lenovo_cnos"] = "lenovo_cnos" | ||
| _MAIN_LIB_MAPPER["lenovo_enos"] = "lenovo_enos" | ||
| _MAIN_LIB_MAPPER["mikrotik_routeros_api"] = "mikrotik_routeros_api" |
Contributor
There was a problem hiding this comment.
we should not have _api on these. When we use this in nornir_nautobot, it will have to come with a preferred driver (meaning netmiko, napalm, or api) that will make this work. This should just be the defintions of the mappings.
Contributor
Author
There was a problem hiding this comment.
ok so this should not refer to any nautobot platform, just define the OS name.
jeffkala
approved these changes
Oct 26, 2023
jeffkala
approved these changes
Oct 26, 2023
michalis1
pushed a commit
to michalis1/netutils
that referenced
this pull request
Feb 2, 2026
* modified: netutils/lib_mapper.py * Update lib_mapper.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds the following platforms to MAIN_LIB: