Adds tcp/udp port mapper

[jtdub]

Adds tcp/udp port mapper from: https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml

[jeffkala]

Does it make sense to sort this? Obviously that doesn't change the code much, but thinking for readability of the code.

[itdependsnetworks]

Yes, I agree. I guess sort by number?

[qduk]

I think this will definitely be useful. Thanks for the PR!

[jeffkala]

Looks good now. Thanks for sorting it.

[jtdub]

You're welcome. :)

[itdependsnetworks]

Actually, what did you do when there was a different tcp vs udp?

doip-data | 13400 | tcp | DoIP Data
doip-disc | 13400 | udp | DoIP Discovery

[jtdub]

@itdependsnetworks

I didn't take that into account, but I can!

import csv

TCP_PORT = {}
TCP_NUM_TO_NAME = {}

with open("service-names-port-numbers.csv") as f:
    reader = csv.reader(f)
    for row in reader:
        if row[0] and row[1]:
            try:
                key_exists = TCP_PORT.get(row[1])
                if not key_exists:
                    TCP_PORT[int(row[1])] = row[0].upper()
            except ValueError:
                continue

for k in sorted(TCP_PORT):
    v = TCP_PORT[k]
    TCP_NUM_TO_NAME[k] = v

print(TCP_NUM_TO_NAME)

[jtdub]

I broke out the individual protocols per @itdependsnetworks catch.

[jeffkala]

Didn't realize pkg_resources was in the standard library, so this is all fixed now. I just checkout'd out the PR and ran the tests and it works.

[jeffkala]

Looks good now, tested it locally and seems to work as expected.

[jeffkala]

Didn't realize pkg_resources was in the standard library, so this is all fixed now. I just checkout'd out the PR and ran the tests and it works.

Realizing this is not actually the case, appears pip installs this. When i setup a new venv without pip this isn't importable.

not approved now that pkg_resources is not std lib

[jeffkala]

Think this gets us back to the original solution to just load the JSON file @jtdub , this is what we'd prefer to avoid adding dependencies.

Update as needed if I missed anything.

[itdependsnetworks]

Thanks!