-
Notifications
You must be signed in to change notification settings - Fork 63
Add interface sorting support. #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
qduk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgjustice gotta say, this is pretty awesome stuff. I've just got one other note.
Docs is picking up on your character classes and helper functions. I personally don't think those need to be in there. I am able to get them undocumented by making them private functions. I'll defer to @itdependsnetworks and @jeffkala to see if they agree or not.
Thanks again @dgjustice. Once this is merged it'll allow me to build out my PR.
Co-authored-by: Adam Byczkowski <[email protected]>
I can't say I have a huge issue either way on whether those show up in the docs. To me more is always better in docs, but I understand the concern. |
jeffkala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an awesome addition. Learned a ton just from reading over the code. Thanks @dgjustice
Co-authored-by: Adam Byczkowski <[email protected]>
|
Travis is being flaky again. I think the last commit is clean (passes tests); the build failed on installing dependencies. |
qduk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jeffkala You make a good point. Never hurts to have the extra documentation.
@dgjustice Thanks for adding the docstring example.
@qduk I have refactored the gist I sent (thank you for pointing out how broken that was! 😬). I finally put together a proper PR with all the test cases I could find. This is a bit more complexity, but taking the "character class" approach allows future modifications to completely customize the sorting logic based on arbitrary groups of characters. Sorts happen first by
CharacterClass.weight, and secondly by whatever logic you like, for example, casting tointfor theCCIntclass.