Acl check #290
Merged
Acl check #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itdependsnetworks
requested review from
abates,
jeffkala and
qduk
as code owners
jeffkala
reviewed
Jun 12, 2023
chadell
reviewed
Jul 28, 2023
chadell
left a comment
chadell
left a comment
There was a problem hiding this comment.
I think it's an interesting feature to manage ACL entries. Obviously, maybe the biggest gap is a proper documentation to understand how to use aside of reviewing the tests
itdependsnetworks
force-pushed
the
acl-check
branch
from
76c3bbd to
813e557
Compare
Contributor
Author
|
Skipped some of the larger files in some of the linters to speed things up as well.
|
itdependsnetworks
force-pushed
the
acl-check
branch
2 times, most recently
from
1c27528 to
8bbf9aa
Compare
mzbroch
reviewed
Jul 31, 2023
mzbroch
reviewed
Jul 31, 2023
mzbroch
reviewed
Jul 31, 2023
mzbroch
reviewed
Jul 31, 2023
mzbroch
reviewed
Jul 31, 2023
Contributor
mzbroch
left a comment
mzbroch
left a comment
There was a problem hiding this comment.
Leaving my first comments
chadell
reviewed
Aug 1, 2023
chadell
left a comment
chadell
left a comment
There was a problem hiding this comment.
I like the naming better now. I think it's a useful auxiliary code for managing ACLs.
itdependsnetworks
force-pushed
the
acl-check
branch
from
6a56b4e to
83abaee
Compare
jeffkala
previously requested changes
Aug 4, 2023
mzbroch
reviewed
Aug 4, 2023
qduk
reviewed
Aug 15, 2023
Collaborator
qduk
left a comment
qduk
left a comment
There was a problem hiding this comment.
I thought the docs were pretty easy to follow. No real code suggestions just a few grammar things. I think this will be very useful!
docs/user/lib_use_cases_acl.md
Outdated
Collaborator
There was a problem hiding this comment.
Suggested change
| The intention of this page is not to cover every attribute and it's behavior, but a more human (although highly technical) understanding of what is going on. For more detailed information, please see the [test](https://github.com/networktocode/netutils/blob/develop/tests/unit/test_acl.py) and [code docs](../../dev/code_reference/acl/). | |
| The intention of this page is not to cover every attribute and its behavior, but a more human (although highly technical) understanding of what is going on. For more detailed information, please see the [test](https://github.com/networktocode/netutils/blob/develop/tests/unit/test_acl.py) and [code docs](../../dev/code_reference/acl/). |
qduk
approved these changes
Aug 15, 2023
jeffkala
approved these changes
Aug 15, 2023
Co-authored-by: Jeff Kala <[email protected]>
itdependsnetworks
force-pushed
the
acl-check
branch
from
f01b9c6 to
7b884ff
Compare
Co-authored-by: Adam Byczkowski <[email protected]> Co-authored-by: Jeff Kala <[email protected]>
michalis1
pushed a commit
to michalis1/netutils
that referenced
this pull request
Feb 2, 2026
Co-authored-by: Jeff Kala <[email protected]> Co-authored-by: Adam Byczkowski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.