fix classfull address naming #173
Conversation
fix classfull address naming in ip.py
vivekvashist
requested review from
abates,
itdependsnetworks,
jeffkala and
qduk
as code owners
|
I think if we're being pedantic, it should be |
Ah, that is technically correct - If you want I can update this RR and resubmit. |
netutils/ip.py
Outdated
|
|
||
| def is_classfull(ip_network: str) -> bool: # noqa: D300,D301 | ||
| """Determines if a CIDR network address is within unicast class full boundaries. | ||
| """Determines if a CIDR network address is within unicast classfull boundaries. |
There was a problem hiding this comment.
| """Determines if a CIDR network address is within unicast classfull boundaries. | |
| """Determines if a CIDR network address is within unicast classful boundaries. |
netutils/ip.py
Outdated
|
|
||
| Returns: | ||
| Whether or not the network falls within class full boundaries. | ||
| Whether or not the network falls within classfull boundaries. |
There was a problem hiding this comment.
| Whether or not the network falls within classfull boundaries. | |
| Whether or not the network falls within classful boundaries. |
netutils/ip.py
Outdated
| """ | ||
| net = ipaddress.ip_network(ip_network) | ||
| # Only IPv4 addresses can be classified as class full | ||
| # Only IPv4 addresses can be classified as classfull |
There was a problem hiding this comment.
| # Only IPv4 addresses can be classified as classfull | |
| # Only IPv4 addresses can be classified as classful |
netutils/ip.py
Outdated
| @@ -159,7 +159,7 @@ def ip_subtract(ip: str, val: int) -> str: | |||
|
|
|||
|
|
|||
| def is_classfull(ip_network: str) -> bool: # noqa: D300,D301 | |||
There was a problem hiding this comment.
| def is_classfull(ip_network: str) -> bool: # noqa: D300,D301 | |
| def is_classful(ip_network: str) -> bool: # noqa: D300,D301 |
Since you already have a PR going those changes would be great. I still can't believe I spelled it wrong in the first place 🤦 |
|
Apologies, I got my branching messed up and accidentally created a new PR :( |
|
@vivekvashist: No worries. Can the other PR be closed? |
|
Done. |
|
Closing as #174 addressed the issue. |
|
Not sure if this was closed by accident but the following changes are are still pending |
|
@vivekvashist we got confused with the other PR and thought these changes had already been merged. |
|
@vivekvashist can you please fix this PR so that the tests pass? |
|
* Minor updates fix classfull address naming in ip.py * PR#networktocode#173 Fix classful naming * fixing broken tests
5 participants
No description provided.