Add ASA Parser #16
Add ASA Parser #16
Conversation
jdrew82
requested review from
itdependsnetworks,
jeffkala and
qduk
as code owners
netutils/config/parser.py
Outdated
| banner_start = [] | ||
|
|
||
|
|
||
| class ASAConfigParser(CiscoConfigParser, BaseSpaceConfigParser): |
There was a problem hiding this comment.
CiscoConfigParser already inherits from BaseSpaceConfigParser, e.g. class CiscoConfigParser(BaseSpaceConfigParser):
This should suffice class ASAConfigParser(CiscoConfigParser):
There was a problem hiding this comment.
This is due to using IOSConfigParser as an example and it inherits from those two classes. I will correct it.
|
Can you add tests/mocked examples for all of the compliance functions? e.g. in folder |
|
I'll work on getting those tests added today. |
| ... ] | ||
| True | ||
| """ | ||
| for line in self.generator_config: |
There was a problem hiding this comment.
@jmcgill298 Can you give this a quick review? I get lost a little bit what this is doing, but it seems like there is a logical reason to overwrite this method.
Please feel free to review entire PR as everything looks good to me and I am inclined to merge.
There was a problem hiding this comment.
It was overwritten because the ASA does the banner differently. Instead of needing to parse it like it's a single line with a delimiter, you can just parse each line individually like normal since each line always starts with the banner keyword, ie:
banner motd <BANNER TEXT>
banner exec <BANNER TEXT>
There was a problem hiding this comment.
Thanks!! That makes sense.
4 participants
This is an initial attempt at a parser for ASAs to address #10.