Skip to content

Convert to new style mkdocs #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
itdependsnetworks merged 2 commits into from
Oct 12, 2022
Merged

Convert to new style mkdocs #152

itdependsnetworks merged 2 commits into from
Oct 12, 2022

Conversation

@itdependsnetworks
Copy link
Contributor

@itdependsnetworks itdependsnetworks commented Oct 10, 2022 •
edited
Loading

Fixes #88, #127, #131, and #150

@itdependsnetworks itdependsnetworks mentioned this pull request Oct 10, 2022
Closed
@jeffkala
Copy link
Collaborator

jeffkala commented Oct 11, 2022

should code_references be nested under /docs/dev or just /docs?

@itdependsnetworks
Copy link
Contributor Author

itdependsnetworks commented Oct 11, 2022

should code_references be nested under /docs/dev or just /docs?

This is the standard already, I just followed it.

@jeffkala
Copy link
Collaborator

jeffkala commented Oct 11, 2022

All good then. Will do my review now.

jeffkala
jeffkala requested changes Oct 11, 2022
View reviewed changes
@qduk
Copy link
Collaborator

qduk commented Oct 12, 2022

I may just be missing it, but I don't see the functions for each file. Something equivalent to this

@itdependsnetworks
Copy link
Contributor Author

itdependsnetworks commented Oct 12, 2022 •
edited
Loading

I may just be missing it, but I don't see the functions for each file. Something equivalent to this

https://github.com/networktocode/netutils/pull/152/files#diff-34ec211d37292b70f8207ed7f4785ca06077f5ae7d67f5e8549ec5b4e47f20a0R5 as one example.

@itdependsnetworks
Copy link
Contributor Author

itdependsnetworks commented Oct 12, 2022

I documented this as well: https://github.com/networktocode/netutils/pull/152/files#diff-77427b00199d45ca27f2bd25934e2348693fada0e1e8b25986b7a2c388bce01eR34-R40

qduk
qduk approved these changes Oct 12, 2022
View reviewed changes
Copy link
Collaborator

@qduk qduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itdependsnetworks itdependsnetworks merged commit 558d71a into networktocode:develop Oct 12, 2022
This was referenced Oct 12, 2022
Closed
Closed
Closed
itdependsnetworks added a commit to itdependsnetworks/netutils that referenced this pull request Nov 3, 2022
@itdependsnetworks @jeffkala
Convert to new style mkdocs (networktocode#152)
5bd5e8e 
Co-authored-by: Ken Celenza <[email protected]>
Co-authored-by: Jeff Kala <[email protected]>
michalis1 pushed a commit to michalis1/netutils that referenced this pull request Feb 2, 2026
@itdependsnetworks @jeffkala
Convert to new style mkdocs (networktocode#152)
ffdd72a 
Co-authored-by: Ken Celenza <[email protected]>
Co-authored-by: Jeff Kala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeffkala jeffkala jeffkala requested changes

@qduk qduk qduk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Readme for adding a parser.

3 participants

@itdependsnetworks @jeffkala @qduk