Skip to content

Conversation

@jeffkala
Copy link
Collaborator

fix #95

@itdependsnetworks
Copy link
Contributor

Can you add the optional dependencies, our json schema repo should show how that is done. Need to add tests as well

@itdependsnetworks
Copy link
Contributor

I think that we need to document how to install the optional dependencies and when to install them

@jeffkala
Copy link
Collaborator Author

jeffkala commented Oct 3, 2022

Will work on getting docs updated.

@jeffkala
Copy link
Collaborator Author

jeffkala commented Oct 4, 2022

should be ready now.

run: "poetry run invoke pylint"
needs:
- "build"
pytest_all:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to separate out, the ci can just run with pytest-all, no? Otherwise, creating more steps in the github actions runs

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right now pytest only runs 1 test, and that is the check to make sure the exception is raised on the get_napalm_getters() when napalm is not installed. pytest-all runs every other test including testing the actual get_napalm_getters() functionality when napalm is installed. I must be missing something on what you're asking.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something like

    strategy:
      fail-fast: true
      matrix:
        python-version: ["3.7", "3.8", "3.9", "3.10"]
        testing-type: "pytest_all"
        include:
          - python-version: "3.10"
            testing-type: "pytest"

pydocstyle = "*"
m2r2 = "*"
sphinx = "*"
sphinx-rtd-theme = "*"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can likely remove as well, (missed by me)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

along with m2r2

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing m2r2 is good, once I remove sphinx-rtd-theme I can no longer build.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see initial pipeline failure

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed m2r2, left sphinx-rtd-theme for now until we determine what is using this dependency and while builds start to fail once its removed.

@jeffkala
Copy link
Collaborator Author

@qduk want to review?

Copy link
Collaborator

@qduk qduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@itdependsnetworks itdependsnetworks merged commit 0ef3d37 into develop Oct 19, 2022
@itdependsnetworks itdependsnetworks deleted the jkala-napalmgetters branch October 30, 2022 18:08
itdependsnetworks pushed a commit to itdependsnetworks/netutils that referenced this pull request Nov 3, 2022
michalis1 pushed a commit to michalis1/netutils that referenced this pull request Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Napalm Supported Getter Matrix (as code)

3 participants