Adds get_oui and flat ci process to pull OUI data into repo #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{
"date": "2022-09-12T18:38:07.891Z",
"files": [
{
"name": "test.txt",
"deltaBytes": 5253172,
"source": "https://standards-oui.ieee.org"
}
]
}
{
"date": "2022-09-12T19:24:55.944Z",
"files": [
{
"name": "netutils/oui_mappings.py",
"deltaBytes": 5253172,
"source": "https://standards-oui.ieee.org"
}
]
}
{
"date": "2022-09-12T19:42:33.332Z",
"files": [
{
"name": "netutils/oui_mappings.py",
"deltaBytes": -3971512,
"source": "https://standards-oui.ieee.org"
}
]
}
{
"date": "2022-09-12T19:46:33.601Z",
"files": [
{
"name": "netutils/oui_mappings.py",
"deltaBytes": 3971512,
"source": "https://standards-oui.ieee.org"
}
]
}
{
"date": "2022-09-12T20:17:34.717Z",
"files": [
{
"name": "netutils/oui_mappings.py",
"deltaBytes": -3971512,
"source": "https://standards-oui.ieee.org"
}
]
}
{
"date": "2022-09-12T20:23:39.725Z",
"files": [
{
"name": "netutils/oui_mappings.py",
"deltaBytes": 0,
"source": "https://standards-oui.ieee.org"
}
]
}
{
"date": "2022-09-12T20:38:29.667Z",
"files": [
{
"name": "netutils/oui_mappings.py",
"deltaBytes": 1,
"source": "https://standards-oui.ieee.org"
}
]
}
{
"date": "2022-09-12T20:55:56.830Z",
"files": [
{
"name": "netutils/oui_mappings.py",
"deltaBytes": 1,
"source": "https://standards-oui.ieee.org"
}
]
}
{
"date": "2022-09-12T21:02:54.064Z",
"files": [
{
"name": "netutils/oui_mappings.py",
"deltaBytes": -2,
"source": "https://standards-oui.ieee.org"
}
]
}
{
"date": "2022-09-21T17:48:18.614Z",
"files": [
{
"name": "netutils/oui_mappings.py",
"deltaBytes": 32,
"source": "https://standards-oui.ieee.org"
}
]
}
{
"date": "2022-09-21T17:51:36.253Z",
"files": [
{
"name": "netutils/oui_mappings.py",
"deltaBytes": 1,
"source": "https://standards-oui.ieee.org"
}
]
}
Collaborator
Author
|
Updated to align with what we discussed in Slack. Let me know what you guys think! |
Contributor
|
would be interested to see the memory impact with and without calling that function |
jeffkala
reviewed
Sep 23, 2022
Collaborator
Author
|
@itdependsnetworks Looks like it is about a 6.707 MiB increase in memroy usage once that python dict is imported. |
Collaborator
Author
|
Here is calling a different function to show memory usage stays at ~22. |
Collaborator
|
@qduk test are failing |
Collaborator
Author
|
@jeffkala @itdependsnetworks Fixed tests. Thanks Jeff. |
jeffkala
approved these changes
Oct 5, 2022
Co-authored-by: Jeff Kala <[email protected]>
itdependsnetworks
approved these changes
Oct 6, 2022
Closed
itdependsnetworks
pushed a commit
to itdependsnetworks/netutils
that referenced
this pull request
Nov 3, 2022
…ocode#148) Adds get_oui and flat ci process to pull OUI data into repo (networktocode#148) Co-authored-by: Jeff Kala <[email protected]> Co-authored-by: Adam Byczkowski <[email protected]> Co-authored-by: flat-data <[email protected]> Co-authored-by: Jeff Kala <[email protected]>
michalis1
pushed a commit
to michalis1/netutils
that referenced
this pull request
Feb 2, 2026
…ocode#148) Adds get_oui and flat ci process to pull OUI data into repo (networktocode#148) Co-authored-by: Jeff Kala <[email protected]> Co-authored-by: Adam Byczkowski <[email protected]> Co-authored-by: flat-data <[email protected]> Co-authored-by: Jeff Kala <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #119. The CI schedule is defined to pull data every 15th of the month. If there is a difference in the data, the flat CI action will commit the new data to the repo. I'm not sure how exactly we want to handle that. I'm sure we could make it where it creates a PR rather than a straight commit but figure we start discussion from this PR.