Update banner parsing for EOS #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmcgill298
approved these changes
Jun 22, 2022
Contributor
jmcgill298
left a comment
jmcgill298
left a comment
There was a problem hiding this comment.
Looks good, only thing was missing newlines
tests/unit/mock/config/compliance/compliance/arista_eos/eos_bad_banner_received.json
Outdated
Show resolved
Hide resolved
tests/unit/mock/config/compliance/compliance/arista_eos/eos_basic_received.json
Outdated
Show resolved
Hide resolved
itdependsnetworks
force-pushed
the
eos_banner
branch
from
504e1af to
700f7b6
Compare
Update banner parsing for EOS
jeffkala
approved these changes
Jun 24, 2022
jeffkala
added a commit
that referenced
this pull request
Aug 5, 2022
* Updated lib mapping docs (#113) * Updated lib mapping docs * Updated per review suggestions * Pinned mistune for m2r2 (#114) * Switch to poetry-core * Update banner parsing for EOS (#121) Update banner parsing for EOS * Fixes encrypt type7 (#122) * fixes encrypt type7 * Document support on duplicate lines (#128) * Few updates to PR of 125 (#129) * initial pass at type hinting and getting mypy to run * update tasks and ci to do mypy as well * rm unused import * fix contributing end-line number * fix contributing end-line number * Add py.typed file to signify availability of type hints to third parties. * Updates to type hinting. * Add EOS _build_banner type hints. * Address feedback. * Linting. * Remove .idea from commit and ignore in .gitignore. * Remove remnants of merge conflict. * PR feedback. * PR comments. * Ignore pylint errors for abstract-method. * Black. * add examples and better exception messaging Co-authored-by: Leo Kirchner <[email protected]> * Adding nxos_ssh to Napalm mapper (#138) * Update CODEOWNERS (#134) adding codeowner * prep for 1.2.0 release (#143) * prep for 1.2.0 release * Update CHANGELOG.md Co-authored-by: Jeff Kala <[email protected]> Co-authored-by: Jeff Kala <[email protected]> Co-authored-by: Adam Byczkowski <[email protected]> Co-authored-by: Fabian Affolter <[email protected]> Co-authored-by: Ken Celenza <[email protected]> Co-authored-by: Dr. X <[email protected]> Co-authored-by: Leo Kirchner <[email protected]> Co-authored-by: Joe Wesch <[email protected]> Co-authored-by: Andrew Bates <[email protected]>
itdependsnetworks
added a commit
to itdependsnetworks/netutils
that referenced
this pull request
Nov 3, 2022
Update banner parsing for EOS
itdependsnetworks
added a commit
to itdependsnetworks/netutils
that referenced
this pull request
Nov 3, 2022
* Updated lib mapping docs (networktocode#113) * Updated lib mapping docs * Updated per review suggestions * Pinned mistune for m2r2 (networktocode#114) * Switch to poetry-core * Update banner parsing for EOS (networktocode#121) Update banner parsing for EOS * Fixes encrypt type7 (networktocode#122) * fixes encrypt type7 * Document support on duplicate lines (networktocode#128) * Few updates to PR of 125 (networktocode#129) * initial pass at type hinting and getting mypy to run * update tasks and ci to do mypy as well * rm unused import * fix contributing end-line number * fix contributing end-line number * Add py.typed file to signify availability of type hints to third parties. * Updates to type hinting. * Add EOS _build_banner type hints. * Address feedback. * Linting. * Remove .idea from commit and ignore in .gitignore. * Remove remnants of merge conflict. * PR feedback. * PR comments. * Ignore pylint errors for abstract-method. * Black. * add examples and better exception messaging Co-authored-by: Leo Kirchner <[email protected]> * Adding nxos_ssh to Napalm mapper (networktocode#138) * Update CODEOWNERS (networktocode#134) adding codeowner * prep for 1.2.0 release (networktocode#143) * prep for 1.2.0 release * Update CHANGELOG.md Co-authored-by: Jeff Kala <[email protected]> Co-authored-by: Jeff Kala <[email protected]> Co-authored-by: Adam Byczkowski <[email protected]> Co-authored-by: Fabian Affolter <[email protected]> Co-authored-by: Ken Celenza <[email protected]> Co-authored-by: Dr. X <[email protected]> Co-authored-by: Leo Kirchner <[email protected]> Co-authored-by: Joe Wesch <[email protected]> Co-authored-by: Andrew Bates <[email protected]>
michalis1
pushed a commit
to michalis1/netutils
that referenced
this pull request
Feb 2, 2026
* Updated lib mapping docs (networktocode#113) * Updated lib mapping docs * Updated per review suggestions * Pinned mistune for m2r2 (networktocode#114) * Switch to poetry-core * Update banner parsing for EOS (networktocode#121) Update banner parsing for EOS * Fixes encrypt type7 (networktocode#122) * fixes encrypt type7 * Document support on duplicate lines (networktocode#128) * Few updates to PR of 125 (networktocode#129) * initial pass at type hinting and getting mypy to run * update tasks and ci to do mypy as well * rm unused import * fix contributing end-line number * fix contributing end-line number * Add py.typed file to signify availability of type hints to third parties. * Updates to type hinting. * Add EOS _build_banner type hints. * Address feedback. * Linting. * Remove .idea from commit and ignore in .gitignore. * Remove remnants of merge conflict. * PR feedback. * PR comments. * Ignore pylint errors for abstract-method. * Black. * add examples and better exception messaging Co-authored-by: Leo Kirchner <[email protected]> * Adding nxos_ssh to Napalm mapper (networktocode#138) * Update CODEOWNERS (networktocode#134) adding codeowner * prep for 1.2.0 release (networktocode#143) * prep for 1.2.0 release * Update CHANGELOG.md Co-authored-by: Jeff Kala <[email protected]> Co-authored-by: Jeff Kala <[email protected]> Co-authored-by: Adam Byczkowski <[email protected]> Co-authored-by: Fabian Affolter <[email protected]> Co-authored-by: Ken Celenza <[email protected]> Co-authored-by: Dr. X <[email protected]> Co-authored-by: Leo Kirchner <[email protected]> Co-authored-by: Joe Wesch <[email protected]> Co-authored-by: Andrew Bates <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.