docs(openspec): sync quoted-free-text pattern rule into tool-approval-gates (#1406) - #1816
Merged
Merged
Conversation
…-gates (#1406) Reconcile the spec with the behavior that PR #1815 merged. Add the quoted-free-text termination rule to the "Shell command pattern matching" requirement. The rule sits next to the digit-bearing rule and the multi-line rule. A quoted argument with internal whitespace is call-specific free text and stops pattern extraction. Add four scenarios that pin the shipped constraints: - a multi-word quoted operand drops from the pattern - multi-word quoted operands generalize across values - a single-word quoted argument stays in the pattern - a quoted path keeps directory scoping Archive the completed change under openspec/changes/archive/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reconcile the
tool-approval-gatesspec with the behavior that PR #1815merged for issue #1406. This is the OpenSpec follow-up to that fix.
Changes
matching" requirement in
openspec/specs/tool-approval-gates/spec.md. Therule sits next to the digit-bearing rule (Verb chain extraction includes bare integer positional arguments, creating overly-specific approval patterns #1331) and the multi-line rule
(Multi-line quoted strings break shell approval prompt rendering and stored patterns #1402). A quoted argument with internal whitespace is call-specific free
text and stops pattern extraction.
git commit -m "fix the bug"->git commit -m)openspec/changes/archive/.Notes
live authorization decision. The PR fix(approvals): drop quoted free-text operands from stored approval patterns (#1406) #1815 adversarial review confirmed this.
openspec validatepasses fortool-approval-gates. The pre-existingnetclaw-toolsvalidation failure is unrelated to this change.