Skip to content

Deflake obsolete shell timeout override test #1688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaronontheweb merged 1 commit into from
Jul 17, 2026
Merged

Deflake obsolete shell timeout override test #1688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions src/Netclaw.Actors.Tests/Tools/ShellToolTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,22 +61,6 @@ public async Task Timeout_kills_long_running_process()
Assert.Contains("timed out", result);
}

[Fact]
public async Task Requested_timeout_overrides_default_timeout()
{
var tool = new ShellTool(new ToolConfig(), new ToolPathPolicy([]), new ShellCommandPolicy());
var args = ToolInput.Create("Command", "sleep 1");
var context = TestToolExecutionContext.CreateBound("test/thread", Path.GetTempPath(), new TestToolExecutionContextOptions
{
Audience = TrustAudience.Personal,
ExecutionTimeout = new ToolExecutionTimeout(TimeSpan.FromSeconds(5))
});

var result = await tool.ExecuteAsync(args, context, CancellationToken.None);

Assert.Contains("Exit code: 0", result);
}

[Fact]
public async Task Caller_cancellation_kills_child_process_tree_and_returns_gracefully()
{
Expand Down
Loading