sync - #1748
Merged
Merged
Conversation
Lets users authenticate ntfy notifications through a reverse proxy or tunnel (Pangolin, Tailscale, ...) in front of the ntfy instance. Adds three optional, backward-compatible settings that default to empty and are no-ops when unset: - NTFY_URL_QUERY_STRING: appended to the request URL (e.g. p_token=...). A leading '?' is tolerated, and the value is redacted from error logs / the plugin result file since the request URL can carry a secret token. - NTFY_CUSTOMHEADER_NAME / NTFY_CUSTOMHEADER_VALUE: a custom request header, skipped with a warning if it would clobber a built-in header (e.g. Authorization) so ntfy's own auth stays intact. Secret-bearing fields are password-masked in the UI. Addresses #1663.
Adds README examples for the custom header and URL query string settings, and handles requests' InvalidHeader separately: its message embeds the offending header value, so logging it leaked NTFY_CUSTOMHEADER_VALUE into the plugin result file and the UI.
…ring Add custom header and URL query string options to the ntfy publisher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.