sync by jokob-sk · Pull Request #1244 · netalertx/NetAlertX

jokob-sk · 2025-10-26T21:14:03Z

No description provided.

Signed-off-by: jokob-sk <jokob.sk@gmail.com>

Currently translated at 100.0% (761 of 761 strings) Translation: NetAlertX/core Translate-URL: https://hosted.weblate.org/projects/pialert/core/ca/

Signed-off-by: jokob-sk <jokob.sk@gmail.com>

Adds bare metal installer for ubuntu. Tested with version 24.04. You may want to or have to change the PHPVERSION variable in the start script for other versions

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

get_table_json would throw exceptions when trying to iterate over a NONE result, ie SQL query returned empty result.

Removed 'sudo' from all calls as the script already needs to run as sudo so it's pointless

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Fixes typo in start.ubuntu.sh Redirects output of python server to /dev/null to avoid I/O errors if started from SSH for example

This would throw a subsequent error ['[Database] - get_table_as_json ERROR:', TypeError("'NoneType' object is not iterable")]

IIteration error is not a SQL error, so gotta catch generic errors, too

DB result iteration fix on empty result

Added PRAGMAs for better DB performance on open. Integrated some Fake8 comments and eliminated some looping with more efficient pyton functions.

Ubuntu installer

Added some of the hand picked suggestions, including some outside of the previous changes. Some will improve documentation, some readability and some will affect performance.

Change static route to relative route in URL for proper proxy operation

Added user-agent header

split installer structure into systems, updated non-functional Debian12 installer with some minor fixes to Ubuntu24 installer. Updated docs.

…r-in-website_monitor-script-py Add custom User-Agent header to requests in website monitor script

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

…-config.sh Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

…-config.sh Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Dang it coderabbit. We expect more of your diffs.

Feat: Enterprise-Grade Security Hardening and Build Overhaul

Signed-off-by: jokob-sk <jokob.sk@gmail.com>

Forgot to change git clone branch back to main.

Rename CONTRIBUTING to CONTRIBUTING.md

Change branch back to main.

Signed-off-by: jokob-sk <jokob.sk@gmail.com>

Currently translated at 100.0% (762 of 762 strings) Translation: NetAlertX/core Translate-URL: https://hosted.weblate.org/projects/pialert/core/ru/

coderabbitai · 2025-10-26T21:14:14Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch main

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gitguardian · 2025-10-26T21:15:39Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
8489824	Triggered	Generic Password	`798d246`	install/alpine-docker/app/config/app.conf	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

jokob-sk and others added 30 commits September 8, 2025 21:17

docs

840e1e5

Signed-off-by: jokob-sk <jokob.sk@gmail.com>

Translated using Weblate (Catalan)

6d8f451

Currently translated at 100.0% (761 of 761 strings) Translation: NetAlertX/core Translate-URL: https://hosted.weblate.org/projects/pialert/core/ca/

docs

1688d02

Signed-off-by: jokob-sk <jokob.sk@gmail.com>

Merge branch 'main' of https://github.com/jokob-sk/NetAlertX

2df7d14

weblate

2b2ae51

Signed-off-by: jokob-sk <jokob.sk@gmail.com>

Ubuntu installer

1399e38

Adds bare metal installer for ubuntu. Tested with version 24.04. You may want to or have to change the PHPVERSION variable in the start script for other versions

Update install/ubuntu/install.ubuntu.sh

b0d117c

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Update install/ubuntu/start.ubuntu.sh

7863ab3

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Update install/ubuntu/start.ubuntu.sh

2482289

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Update install/ubuntu/start.ubuntu.sh

f64cd9e

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Update install/ubuntu/start.ubuntu.sh

c6f0614

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

DB result iteration fix on empty result

a94c6a2

get_table_json would throw exceptions when trying to iterate over a NONE result, ie SQL query returned empty result.

Fixes

db43ab9

Removed 'sudo' from all calls as the script already needs to run as sudo so it's pointless

Update server/db/db_helper.py

2836996

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Minor updates

d31af28

Fixes typo in start.ubuntu.sh Redirects output of python server to /dev/null to avoid I/O errors if started from SSH for example

Some more fixes

9998175

fixed get_table_json

24eaf1e

This would throw a subsequent error ['[Database] - get_table_as_json ERROR:', TypeError("'NoneType' object is not iterable")]

Another fix to get_table_json

7f7b0a3

IIteration error is not a SQL error, so gotta catch generic errors, too

Final fix

ccec89f

Merge pull request #1167 from ingoratsdorf/db-work

cb63dd1

DB result iteration fix on empty result

DB functions tidyup

3390384

Added PRAGMAs for better DB performance on open. Integrated some Fake8 comments and eliminated some looping with more efficient pyton functions.

Merge branch 'jokob-sk:main' into db-caching

f1e9ca2

Merge pull request #1166 from ingoratsdorf/ubuntu

3653d2e

Ubuntu installer

CodeRabbit suggestionns

1874a5e

Added some of the hand picked suggestions, including some outside of the previous changes. Some will improve documentation, some readability and some will affect performance.

Update deviceDetailsTools.php

de20a26

Change static route to relative route in URL for proper proxy operation

Update script.py

a823301

Added user-agent header

Merge branch 'jokob-sk:main' into db-caching

786ae93

Installer-rework

db42d7f

split installer structure into systems, updated non-functional Debian12 installer with some minor fixes to Ubuntu24 installer. Updated docs.

Delete old Debian12 files

e0ffe8b

Merge pull request #1171 from cvc90/NetAlertX-Adding-user-agent-heade…

ad9babd

…r-in-website_monitor-script-py Add custom User-Agent header to requests in website monitor script

adamoutler and others added 26 commits October 19, 2025 14:18

Coderabbit suggestions

a58b3e3

Fix fish terminal. Smarter code completion and other nicities.

131c0c0

Coderabbit nitpicks.

dcf250d

Add novel coderabit no-write database creation

84f1283

Update .devcontainer/scripts/setup.sh

8eab7ee

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Update install/production-filesystem/services/scripts/check-first-run…

86bf0a3

…-config.sh Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Update install/production-filesystem/services/scripts/update_vendors.sh

999feb2

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Update install/production-filesystem/services/scripts/update_vendors.sh

660f0c2

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

add caps to python instead of scapy.

066fecf

Remove unused pythonpathpath variable

628f35c

Set caps on actual python3.12

5ed46da

Update install/production-filesystem/services/scripts/check-first-run…

ea4c70e

…-config.sh Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Remove duplicate file replacement logic in update_vendors.sh

6f2e556

Dang it coderabbit. We expect more of your diffs.

Merge pull request #1230 from adamoutler/hardening

5d7af88

Feat: Enterprise-Grade Security Hardening and Build Overhaul

BE: install refactor work

6a20128

Signed-off-by: jokob-sk <jokob.sk@gmail.com>

Rename CONTRIBUTING to CONTRIBUTING.md

c278865

Change branch back to main.

05890b3

Forgot to change git clone branch back to main.

Merge pull request #1236 from AlmazzikDev/patch-1

fe69bc4

Rename CONTRIBUTING to CONTRIBUTING.md

Merge pull request #1237 from JVKeller/patch-3

bb35417

Change branch back to main.

DOCS: install refactor work

fe69972

Signed-off-by: jokob-sk <jokob.sk@gmail.com>

PLUG: SNMPDSC timeout not respected #1231

170aeb0

Signed-off-by: jokob-sk <jokob.sk@gmail.com>

BE: 0 in device tiles #1238

8ada2c3

Signed-off-by: jokob-sk <jokob.sk@gmail.com>

PLUG: 0 in device tiles #1238

b44369a

Signed-off-by: jokob-sk <jokob.sk@gmail.com>

DOCS: clearer local_path instructions

dfc64fd

Signed-off-by: jokob-sk <jokob.sk@gmail.com>

PLUG: SNMPDSC timeout multiplier #1231

2663227

Signed-off-by: jokob-sk <jokob.sk@gmail.com>

Translated using Weblate (Russian)

816b907

Currently translated at 100.0% (762 of 762 strings) Translation: NetAlertX/core Translate-URL: https://hosted.weblate.org/projects/pialert/core/ru/

jokob-sk merged commit 5dba0f1 into next_release Oct 26, 2025
6 of 7 checks passed

rhussmann mentioned this pull request Aug 3, 2026

UNFIMP sets devLastIP to 0.0.0.0 when UniFi controller doesn't report client IP (related to #1207, #1717) #1727

Closed

7 tasks

Navigation Menu

Uh oh!

Uh oh!

sync - #1244

sync#1244
jokob-sk merged 823 commits into
next_releasefrom
main

jokob-sk commented Oct 26, 2025

Uh oh!

coderabbitai Bot commented Oct 26, 2025

Review skipped

Uh oh!

Uh oh!

gitguardian Bot commented Oct 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Uh oh!

Uh oh!

Conversation

jokob-sk commented Oct 26, 2025

Uh oh!

coderabbitai Bot commented Oct 26, 2025

Review skipped

Uh oh!

Uh oh!

gitguardian Bot commented Oct 26, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants