Draft
Conversation
- Send Cache-Control private max-age for GET .../book/file - ETag from stable source_file_ref so revalidation avoids full body - Content-Disposition inline for in-browser viewing (fetch still works) - Return 304 when If-None-Match matches Co-authored-by: Terry Yin <terry.yinzhe@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The book reader loads the PDF via
GET /api/notebooks/{id}/book/file. That response did not advertise cacheability and usedContent-Disposition: attachment, which is oriented toward downloads rather than in-app viewing.Changes
Cache-Control:private, longmax-age(365 days),must-revalidateso the client can reuse the response while still revalidating when appropriate.ETag: Derived from the stable storage ref (source_file_ref), so it changes when the underlying blob changes without hashing the full PDF on every request.If-None-Match: Returns 304 Not Modified when the client sends a matching ETag.Content-Disposition: Switched fromattachmenttoinlineso browsers treat the resource as viewable in-page (the app still usesfetch+ pdf.js; filename is preserved for save-as if needed).Tests
NotebookBooksControllerTestfor cache headers, ETag, and 304 behavior.Slack Thread