Merge pull request #35713 from openedx/feanil/ubuntu-24.04#57
Conversation
feanil/ubuntu 24.04
…4.04 feanil/ubuntu 24.04" This reverts commit e6792de.
andrey-canon
force-pushed
the
and/backport_ubuntu-24.04
branch
from
b8f7953 to
1b07b3b
Compare
| sudo apt-get update && sudo apt-get install libmysqlclient-dev libxmlsec1-dev lynx | ||
| sudo apt-get update && sudo apt-get install libmysqlclient-dev libxmlsec1-dev lynx openssl | ||
|
|
||
| # This is needed until the ENABLE_BLAKE2B_HASHING can be removed and we |
There was a problem hiding this comment.
could you clarify more this. I think thats the reason in upstream the md4 is not used.
https://github.com/openedx/edx-platform/blob/master/.github/workflows/unit-tests.yml#L75
There was a problem hiding this comment.
this comes from upstream openedx@1804fbb
| run: | | ||
| make base-requirements | ||
|
|
||
| - uses: c-hive/gha-npm-cache@v1 |
There was a problem hiding this comment.
You removed the cache action, but upper the cache attribute is not added in the actions/setup-node@v4
https://github.com/openedx/edx-platform/pull/36502/files
| - name: Setup mongodb user | ||
| run: | | ||
| mongosh edxapp --eval ' | ||
| docker exec ${{ job.services.mongo.id }} mongosh edxapp --eval ' |
There was a problem hiding this comment.
THis commit could be a cherry-pick openedx@d8eef6e
There was a problem hiding this comment.
I left the code source in every commit
To make a cherry pick is an annoying action that requires to solve multiple unrelated conflicts
| node-version: [ 18 ] | ||
| npm-version: [ 10.5.x ] | ||
| mongo-version: ["4.4", "7.0"] | ||
| mongo-version: ["7.0"] |
There was a problem hiding this comment.
Maybe with this cherry-pick openedx@4687dae
we could also drop support of python3.8
There was a problem hiding this comment.
Out of the scope, I have to remove mongo because that was not compatible with new ubuntu images and current configuration
johanseto
left a comment
johanseto
left a comment
There was a problem hiding this comment.
As all checks passed. LGTM
andrey-canon
merged commit 0ae86d7
into
open-release/redwood.nelp
3 participants
Description
This is a backport from openedx#35713