fix: claude-lane/task_1780281368494_s33opior9-20260602124820#6
Merged
nehraa merged 1 commit intoJun 3, 2026
Merged
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review Summary by QodoPrevent concurrent index operations with termination wait
WalkthroughsDescription• Add concurrency control to prevent duplicate index operations • Introduce waitForTermination() method to wait for in-flight operations • Call waitForTermination() in ensureLoadedState() before state checks • Ensure consistent state observation across concurrent index operations Diagramflowchart LR
A["ensureLoadedState() called"] --> B["waitForTermination()"]
B --> C["Check activeIndexPromise"]
C --> D["Wait for settlement"]
D --> E["Proceed with state check"]
E --> F["Prevent duplicate index runs"]
File Changes1. src/service/coderag.ts
|
Code Review by Qodo
Context used✅ Compliance rules (platform):
9 rules 1. No tests for waitForTermination()
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates dependency configurations in package-lock.json, adjusting peer dependency flags for various packages. In src/service/coderag.ts, a new waitForTermination method is introduced to await any in-flight index operations, and ensureLoadedState is updated to call this method to prevent duplicate index runs. There are no review comments provided, and I have no additional feedback on these changes.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+84
to
+109
| /** | ||
| * Waits for any in-flight index operation to settle so that subsequent | ||
| * operations observe a consistent state. Errors are intentionally swallowed | ||
| * here because the original caller of the index operation already receives | ||
| * the rejection through its returned promise. | ||
| */ | ||
| async waitForTermination(): Promise<void> { | ||
| if (this.activeIndexPromise) { | ||
| await this.activeIndexPromise.catch(() => { | ||
| /* original caller receives the error */ | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| private async ensureLoadedState(): Promise<LoadedState> { | ||
| if (this.loadedState) { | ||
| return this.loadedState; | ||
| } | ||
|
|
||
| // Wait for any in-flight index operation to settle before checking disk state, | ||
| // so we never spawn a duplicate index run while another is still running. | ||
| await this.waitForTermination(); | ||
|
|
||
| if (this.loadedState) { | ||
| return this.loadedState; | ||
| } |
There was a problem hiding this comment.
1. No tests for waitfortermination() 📘 Rule violation ▣ Testability
Indexing coordination was changed by adding waitForTermination() and calling it from ensureLoadedState(), but there is no test that exercises this new in-flight index waiting behavior. This risks regressions where a query/lookup can race an in-progress index and reintroduce duplicate index runs or inconsistent loaded state.
Agent Prompt
## Issue description
`CodeRag.ensureLoadedState()` now waits for an in-flight index operation via the new `waitForTermination()` helper, but the test suite does not include coverage for this new coordination behavior.
## Issue Context
This change is part of indexing lifecycle/locking behavior (index creation/update coordination). Per compliance, modified indexing behavior must be covered by automated tests with assertions that would fail if the behavior is removed.
## Fix Focus Areas
- src/service/coderag.ts[84-123]
- src/test/coderag.test.ts[167-233]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+103
to
+106
| // Wait for any in-flight index operation to settle before checking disk state, | ||
| // so we never spawn a duplicate index run while another is still running. | ||
| await this.waitForTermination(); | ||
|
|
There was a problem hiding this comment.
2. Unbounded index wait 🐞 Bug ☼ Reliability
ensureLoadedState() now awaits waitForTermination(), which awaits activeIndexPromise without any timeout; if an index operation never settles, lookups/queries that need loaded state can hang indefinitely. Index operations include potentially long-running/remote vectorStore calls, while the repo’s lock-wait path already has a timeout but is bypassed by this in-process wait.
Agent Prompt
## Issue description
`CodeRag.ensureLoadedState()` now calls `await this.waitForTermination()`, and `waitForTermination()` awaits `activeIndexPromise` with no timeout. If the index promise never resolves/rejects (e.g., a stuck vector store call), all operations that require `ensureLoadedState()` can block indefinitely.
## Issue Context
- Indexing work includes `vectorStore.reset/upsert/deleteByNodeIds` which are async I/O and may stall.
- The codebase already has a bounded-wait pattern via `IndexLock.waitForRelease()` using `locking.timeoutMs`, but `waitForTermination()` does not apply any similar bound.
## Fix Focus Areas
- src/service/coderag.ts[68-123]
- src/store/index-lock.ts[56-75]
- src/indexer/indexer.ts[163-227]
## Suggested fix
- Add an optional `timeoutMs` parameter to `waitForTermination()` (defaulting to `this.config.locking.timeoutMs`).
- Implement the timeout with `Promise.race([activeIndexPromise.catch(...), timeoutPromise])`.
- On timeout, either:
- throw an `IndexingError` explaining that an in-flight index did not terminate in time, or
- log and fall back to the disk-lock wait path (e.g., `await this.indexer.waitForUnlockedState()`), so callers get a bounded failure mode consistent with other lock waits.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
There was a problem hiding this comment.
Pull request overview
This PR introduces additional in-process synchronization in CodeRag so that state-loading operations don’t race with an in-flight indexing operation, alongside an automated regeneration/update of package-lock.json as part of a DevPulse recovery.
Changes:
- Add a helper to await completion of any active index promise before
ensureLoadedState()checks persisted state. - Update
ensureLoadedState()to wait for in-flight indexing to settle to avoid inconsistent/duplicated index behavior. - Regenerate/update
package-lock.json, adding/removing variouspeermetadata flags and introducing a couple of new optional packages.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/service/coderag.ts | Adds an “await active index” step before loading persisted state to reduce in-process races during indexing. |
| package-lock.json | Automated lockfile update (dependency metadata churn, including peer flags and a few new optional packages). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+84
to
+105
| /** | ||
| * Waits for any in-flight index operation to settle so that subsequent | ||
| * operations observe a consistent state. Errors are intentionally swallowed | ||
| * here because the original caller of the index operation already receives | ||
| * the rejection through its returned promise. | ||
| */ | ||
| async waitForTermination(): Promise<void> { | ||
| if (this.activeIndexPromise) { | ||
| await this.activeIndexPromise.catch(() => { | ||
| /* original caller receives the error */ | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| private async ensureLoadedState(): Promise<LoadedState> { | ||
| if (this.loadedState) { | ||
| return this.loadedState; | ||
| } | ||
|
|
||
| // Wait for any in-flight index operation to settle before checking disk state, | ||
| // so we never spawn a duplicate index run while another is still running. | ||
| await this.waitForTermination(); |
Comment on lines
+103
to
+105
| // Wait for any in-flight index operation to settle before checking disk state, | ||
| // so we never spawn a duplicate index run while another is still running. | ||
| await this.waitForTermination(); |
nehraa
deleted the
claude-lane/task_1780281368494_s33opior9-20260602124820
branch
nehraa
restored the
claude-lane/task_1780281368494_s33opior9-20260602124820
branch
nehraa
deleted the
claude-lane/task_1780281368494_s33opior9-20260602124820
branch
nehraa
restored the
claude-lane/task_1780281368494_s33opior9-20260602124820
branch
nehraa
deleted the
claude-lane/task_1780281368494_s33opior9-20260602124820
branch
nehraa
restored the
claude-lane/task_1780281368494_s33opior9-20260602124820
branch
nehraa
deleted the
claude-lane/task_1780281368494_s33opior9-20260602124820
branch
nehraa
restored the
claude-lane/task_1780281368494_s33opior9-20260602124820
branch
nehraa
deleted the
claude-lane/task_1780281368494_s33opior9-20260602124820
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated DevPulse recovery — see commit history.
Recovered by recover_unprd_tasks.py