Create 1898-maximum-number-of-removable-characters.js

[aadil42]

Solved maximum-number-of-removable-characters in JS.

File(s) Added: 1898-maximum-number-of-removable-characters.js
Language(s) Used: JavaScript
Submission URL: https://leetcode.com/problems/maximum-number-of-removable-characters/submissions/977122834/

[aakhtar3]

Suggestion: Avoid internal functions that relay on global scope

[aadil42]

I always see @neetcode-gh writing nested functions to avoid passing the extra arguments. That is why I also do it. I don't like not passing extra arguments. But I'll fix this.

[aadil42]

done

[aakhtar3]

Suggestion: Avoid else

if (true) continue;

return ...;

[aadil42]

done

[aadil42]

Just a kind reminder that I updated the code as suggested.

[aadil42]

@aakhtar3, sorry for the delay. I got busy. I have removed the else case as suggested. Please check.

[aakhtar3]

This will increase space complexity

[aadil42]

I updated the space complexity to n. But we already had s and p as strings we just used them in an array instead of a string. wouldn't time complexity be the same for that? Before we were using n space for string which we were getting as an argument. Now we use the same number of array elements.

In other words, since we're just converting some string of n char to be an array of n elements. Then, the space complexity is the same as before right? because we were already using space(n) for the strings. Let me know if I'm making a mistake. Thank you.

[aakhtar3]

Sting is immutable primitive data type. You can not modify its state or space in memory.

If you split and convert to char array, it will need new space to allow the list to exist.

If you need to modify the string you can split, but if you need to read by index, you do not need to split and it will lower space complexity.

/* Time O(N + N) | Space O(N) */
for (const char of str.split('')) { ... }

/* Time O(N)     | Space O(1) */
for (const char of str) { ... }

/* Time O(N)     | Space O(1) */
for (const index in str) {
    const char = str.charAt(index);
    const char = str[index];
}

[aadil42]

@aakhtar3, I updated the space complexity.

[aakhtar3]

You can reduce the space O(1) by avoiding the split
and just iterate with for (const char of str)

[aadil42]

@aakhtar3, but if we don't convert it to the array then how are we going to update a specific char of the string? See line 18.
I did remove the split method on the binary-search solution and used the bitwise operation to find the mid now. Please check.

[aakhtar3]

Avoid else

[aadil42]

Done.

[aadil42]

@aakhtar3, It's done. I removed the else case.

[aakhtar3]

Use Bitwise

[aadil42]

It's done, using bitwise operation.

[aadil42]

Waiting for an update. I changed the code as suggested.

[aakhtar3]

You can reduce the space O(1) by avoiding the split
and just iterate with for (const char of str)