Give an :id to every member of the stack - #130
Merged
Merged
Conversation
vemv
marked this pull request as ready for review
February 23, 2020 04:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief
Fixes #38
...It uses an alternative approach to that described in #38: Instead of a
supdate-based map, we leverage the fact that all members of the stack are data (arrays of maps).So we can just associate an
:id, and let users customize formatting-stack by writing Clojure however they wish.Notes
The
:idrequirement (w/spec) is a breaking change, because a user that provided a map-based custom member would have to add an:idto have things working again.Users passing a
reifywill see no :id requirement (there's a comment in the diff explaining that).QA plan
Run the provided example, observing that the provided customizations are honored.
Author checklist
examples/folder, in a future, if they keep growing.Reviewer checklist