Repository navigation
build(deps-dev): update dependency eslint-plugin-n to v18.5.0 #266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
master
Choose a base branch
from
renovate/eslint-plugin-n-18.x
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
📦 Dependency
devDependencyの
eslint-plugin-nが18.4.0から18.5.0に上がっています。マイナー更新で、間の18.4.1も含みます。リリースノートを見る限り、破壊的変更、セキュリティ修正、非推奨APIの追加や削除はありません。主な変更点:
prefer-promises/fsがfs.watchも検出対象にするよう修正。file-extension-in-importの拡張子オーバーライドの扱いを修正。tsconfigのキャッシュとresolverの再利用による性能改善。no-mixed-requiresが新しいNode組み込みモジュールを正しく分類するよう修正。Promise.withResolversのサポート開始バージョンを22.0.0に修正。プロジェクトへの影響:
eslint.config.tsではn/recommended-moduleを使い、n/prefer-promises/fsをerrorにしています。fs.watchのコールバックAPIが新しく警告対象になりますが、コードベースではfs.watchを使っていません。testコードで使っているnode:fsの同期APIは対象外なので、新たなlintエラーは出ない見込みです。そのままマージして問題ないと考えます。