Skip to content

Fix #573, add OS_FileSysStatVolume#717

Merged
astrogeco merged 1 commit into
nasa:integration-candidatefrom
jphickey:fix-573-stat-volume
Jan 12, 2021
Merged

Fix #573, add OS_FileSysStatVolume#717
astrogeco merged 1 commit into
nasa:integration-candidatefrom
jphickey:fix-573-stat-volume

Conversation

@jphickey

Copy link
Copy Markdown
Contributor

Describe the contribution
Add OS_FileSysStatVolume as replacement for OS_fsBytesFree and OS_fsBlocksFree.

Fixes #573

Testing performed
Run all unit tests.

Expected behavior changes
New API for getting stats on file system.
Uses existing OS_FileSysStatVolume_Impl call - just exposes it in public API.

System(s) tested on
Ubuntu 20.04

Additional context
This PR is only adding a new API, it is not (yet) deprecating the existing OS_fsBlocksFree/OS_fsBytesFree calls. Applications and CFE will need an update before these calls can be deprecated, but the new API needs to be in place before the existing refs can be fixed.

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Dec 29, 2020
Add OS_FileSysStatVolume as replacement for OS_fsBytesFree and
OS_fsBlocksFree.  Update unit tests and stubs for the new API
call.

Does not (yet) deprecate the existing functions, as references
still need to be updated elsewhere in apps.
@astrogeco astrogeco added CCB-20210106 and removed CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) labels Jan 6, 2021
@astrogeco

Copy link
Copy Markdown
Contributor

CCB 2021-01-06 APPROVED

  • Exposes/promotes some existing functions to public API

@astrogeco astrogeco changed the base branch from main to integration-candidate January 12, 2021 18:47
@astrogeco astrogeco merged commit 3fcac5f into nasa:integration-candidate Jan 12, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Jan 12, 2021
@jphickey jphickey deleted the fix-573-stat-volume branch January 27, 2021 14:09
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OS_fsBlocksFree returns a 32-bit value, but OS_statvfs_t.blocks_free is 64 bit

3 participants