Fix #37, Offset the UDP base port per-CPU#41
Merged
astrogeco merged 1 commit intoMar 23, 2020
Conversation
Avoid port conflicts when having more than one CPU within the same mission load CI_LAB app. Instead of binding to the port directly, add the CPU number as an offset. Subtract 1 so that CPU1 remains at the same port (1234 by default) and cmdUtil is not affected. NOTE: the "cpu number" can be overridden on the command line when using the pc-linux PSP, thereby also permitting the listen point to be tuned for each launch config, if necessary.
Contributor
Author
|
Possible topic for CCB discussion: |
skliper
approved these changes
Mar 16, 2020
Contributor
|
My only concern related to this change was if the community was using CPU number for something else this association could cause breakage. That said it gets reported at startup, it's a lab app, and this solves a port collision issue and doesn't cause me any issues so I'm good with it. |
Contributor
|
CCB 20200318 - Approved |
1 similar comment
Contributor
|
CCB 20200318 - Approved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Avoid port conflicts when having more than one CPU within the same mission load CI_LAB app. Instead of binding to the port directly, add the CPU number as an offset. Subtract 1 so that CPU1 remains at the same port (1234 by default) and cmdUtil is not affected.
NOTE: the "cpu number" can be overridden on the command line when using the pc-linux PSP, thereby also permitting the listen point to be tuned for each launch config, if necessary.
Testing performed
Build using default config, ensure no errors.
Run FSW and test sending commands with
cmdUtil- confirm no impact when using defaults, still listens on port 1234 as before and can send commands.Run FSW using
--cpuid 2switch, confirm that listening port has changed, observing syslog trace:1980-012-14:03:20.25227 CI_LAB listening on UDP port: 1235Confirmed that
cmdUtilstill works to send commands if the--port 1235option is given.Expected behavior changes
--cpuidoption to override (in pc-linux at least).System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.