Fix #181, Reverted broken include path change#182
Closed
skliper wants to merge 1 commit into
Closed
Conversation
jphickey
reviewed
Jul 27, 2020
jphickey
left a comment
jphickey
left a comment
Contributor
There was a problem hiding this comment.
Submitted PR nasa/cFE#786 which fixes this in the cmake toolchain file which (I think) makes more sense than putting this path into MCP750, as it likely applies to all VxWorks targets.
skliper
added
duplicate
Contributor
Author
|
Better fix in nasa/cFE#786, closing as duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #181, broken include paths
Testing performed
Build on vxworks host
Expected behavior changes
Builds without errors.
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC