Skip to content

Fix #153, use sizeof for snprintf buffer sizes in DS_SendHkCmd#154

Open
chillfig wants to merge 1 commit into
nasa:devfrom
chillfig:fix-153-DS_SendHkCmd-snprintf-buffer-update
Open

Fix #153, use sizeof for snprintf buffer sizes in DS_SendHkCmd#154
chillfig wants to merge 1 commit into
nasa:devfrom
chillfig:fix-153-DS_SendHkCmd-snprintf-buffer-update

Conversation

@chillfig

Copy link
Copy Markdown
Contributor

Checklist (Please check before submitting)

Describe the contribution

Testing performed
build, tests, lcov

Expected behavior changes
Nothing functional. Ensures write limit is derived directly from the destination buffer's declared size. Prevents overflow of truncation in the event of a user changing the configuration.

System(s) tested on

  • Hardware: aarch64
  • OS: Ubuntu 24.04.4 LTS
  • Versions 0cd8596 commit of apps/ds + 38eaf4244185bc70aa296f1d8df7687e2f13989d cFS bundle

Additional context
N/A

Third party code
N/A

Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, Vantage Systems Inc

@chillfig chillfig force-pushed the fix-153-DS_SendHkCmd-snprintf-buffer-update branch from 89bef64 to fc27f17 Compare June 29, 2026 19:51
@chillfig chillfig self-assigned this Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DS_SendHkCmd snprintf buffer size arguments mismatch

2 participants