Skip to content

Add support for HMAC SHA-512 API#38

Merged
josesimoes merged 1 commit intomainfrom
add-HMACSHA512
Mar 2, 2026
Merged

Add support for HMAC SHA-512 API#38
josesimoes merged 1 commit intomainfrom
add-HMACSHA512

Conversation

@josesimoes
Copy link
Member

Description

  • Add implementation for HMACSHA512 class.
  • Add corresponding unit tests.
  • Bump native assembly version.

Motivation and Context

How Has This Been Tested?

  • Running unit tests locally on target with support for System.Security.Cryptography.

Screenshots

image

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

- Add implementation for `HMACSHA512` class.
- Add corresponding unit tests.
- Bump native assembly version.
@nfbot nfbot added Type: enhancement New feature or request Type: Unit Tests labels Feb 26, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 26, 2026

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (5)
  • System.Security.Cryptography/HMACSHA512.cs is excluded by none and included by none
  • System.Security.Cryptography/Properties/AssemblyInfo.cs is excluded by none and included by none
  • System.Security.Cryptography/System.Security.Cryptography.nfproj is excluded by none and included by none
  • Tests/System.Security.CryptographyTests/HmacSha512Tests.cs is excluded by none and included by none
  • Tests/System.Security.CryptographyTests/System.Security.CryptographyTests.nfproj is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-HMACSHA512

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 26, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
27.4% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@josesimoes
Copy link
Member Author

Can't move away easily from the duplication Sonarcloud is reporting. Merging anyway.

@josesimoes josesimoes closed this Feb 26, 2026
@nfbot nfbot removed Type: enhancement New feature or request Type: Unit Tests labels Feb 26, 2026
@josesimoes josesimoes deleted the add-HMACSHA512 branch February 26, 2026 23:23
@nfbot nfbot added the invalid This doesn't seem right label Feb 26, 2026
@josesimoes josesimoes restored the add-HMACSHA512 branch March 2, 2026 09:51
@josesimoes josesimoes reopened this Mar 2, 2026
@josesimoes josesimoes added Type: enhancement New feature or request Type: Unit Tests and removed invalid This doesn't seem right labels Mar 2, 2026
@josesimoes josesimoes merged commit 33c0dfe into main Mar 2, 2026
9 of 11 checks passed
@josesimoes josesimoes deleted the add-HMACSHA512 branch March 2, 2026 09:51
josesimoes added a commit that referenced this pull request Mar 2, 2026
josesimoes added a commit that referenced this pull request Mar 2, 2026
josesimoes added a commit that referenced this pull request Mar 2, 2026
@josesimoes josesimoes changed the title Add support for HMACS HA-512 API Add support for HMAC S HA-512 API Mar 2, 2026
@josesimoes josesimoes changed the title Add support for HMAC S HA-512 API Add support for HMAC SHA-512 API Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants