Skip to content

enssdk: Further migrate types and libs to enssdk #1876

@shrugs

Description

@shrugs

reference: #1867 (comment)

  • NormalizedAddress branded type refactor, asLowerCaseAddress becomes asNormalizedAddress etc
  • definitely need something like asInterpretedName to go from Name to InterpretedName with a helpful api for consumers like the example app parsing url params
    • current it just validates, but we should allow converstion
  • refactor the packages/enssdk/src/lib/names.ts utils to accept InterpretedName instead of Name or NormalizedName
    • likely allows us to get rid of NormalizedName entirely — make sure that the protocol acceleration lib can use InterpretedName instead of NormalizedName
    • update the test case in apps/ensapi/src/lib/handlers/params.schema.test.ts to test interpreted names as well as normalized names
  • clean up apps/ensrainbow/src/commands/convert-csv-command.test.ts to use the await expect().resolves pattern
  • manually test resolution with an InterpretedName, making sure to hit packetToBytes at
    • apps/ensapi/src/lib/resolution/resolve-calls-and-results.ts
    • apps/ensapi/src/lib/protocol-acceleration/find-resolver.ts (findResolverWithUniversalResolver)
    • apps/ensapi/src/lib/resolution/resolve-with-universal-resolver.ts

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

Status

Done

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions