fix: commander 15 + Bun fetch dispatcher typing (supersedes #13) - #14
Merged
Merged
Conversation
Bumps the production-dependencies group with 1 update: [commander](https://github.com/tj/commander.js). Updates `commander` from 14.0.3 to 15.0.0 - [Release notes](https://github.com/tj/commander.js/releases) - [Changelog](https://github.com/tj/commander.js/blob/master/CHANGELOG.md) - [Commits](tj/commander.js@v14.0.3...v15.0.0) --- updated-dependencies: - dependency-name: commander dependency-version: 15.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: production-dependencies ... Signed-off-by: dependabot[bot] <support@github.com>
- Bump commander ^14.0.3 -> ^15.0.0 (security/maintenance) - Fix TS2769 fetch overload errors in fetcher.ts: cast init to RequestInit so the undici dispatcher field passes Bun's global fetch typing - Bump engines.node >=18 -> >=20 (commander 15 requires Node 20+) - Supersedes #13 (which carried a broken dispatcher cast + unrelated workflow downgrades) Validated: typecheck clean, build ok, 152 tests pass.
# Conflicts: # src/lib/fetcher.ts
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by nemotron-3-ultra-550b-a55b-20260604:free · 312,018 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #13. That PR bumped commander 12->15 but the test job failed on pre-existing TS2769 fetch-overload errors in
src/lib/fetcher.ts, and it carried a brokendispatcher as unknown as Record<string,unknown>cast plus unrelated CI action downgrades.Changes
commander^14.0.3->^15.0.0RequestInitso the undicidispatcherfield passes Bun's global fetch typing (the priorRecord<string,unknown>cast was not assignable toDispatcher)engines.node>=18->>=20(commander 15 requires Node 20+)Validation (local, Bun 1.3.14)
bun run typecheck— clean (exit 0)bun run build— ok (cli.js + mcp.js bundled)bun run test— 152 pass / 0 fail