fix(STAFF-141736): The app installed on Spanish user profile is unable to relaunch#23
Open
yucelalbar wants to merge 6 commits into
Open
fix(STAFF-141736): The app installed on Spanish user profile is unable to relaunch#23yucelalbar wants to merge 6 commits into
yucelalbar wants to merge 6 commits into
Conversation
kmrashad
reviewed
Jan 30, 2025
kmrashad
reviewed
Jan 31, 2025
| #ifdef SENTRY_PLATFORM_WINDOWS | ||
| wchar_t *relaunch_argvw; | ||
| #endif | ||
| char *relaunch_argv; |
Collaborator
Author
There was a problem hiding this comment.
The sentry implementation is not #ifdef SENTRY_PLATFORM_WINDOWS #else but rather than adding wchar_t overload as an additional method. So, I'm keeping the same functionality and yes I'll use relaunch_argv on appmanager windows
There was a problem hiding this comment.
ok. I think there was earlier impl where relaunch_argv is in else part.
Collaborator
Author
There was a problem hiding this comment.
Yes but I changed it at the recent commits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.