tools: close the last two tight teardown reaps in the coverage suite - #115
Conversation
#112 raised the nginx teardown reap budget to 30s in seven tools but the coverage job drives nine; test_window_cap.py and test_dcz.py kept 10s. test_dcz.py additionally had no TimeoutExpired guard at all, so a slow exit propagated out of the finally and leaked the nginx process, and test_window_cap.py never reaped after kill(), leaving a zombie until interpreter exit. Same 30s budget and kill fallback as the other seven. Also silences RUF059 on an unpacked-but-unused variable in test_dcz.py (pre-existing, gated by the pre-commit ruff hook on the touched file).
|
Warning Review limit reached
Next review available in: 11 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
TL;DR
Two test tools could still fail, or quietly leave an nginx process running, when a coverage-instrumented server was slow to shut down. They now get the same patient shutdown handling as the other seven tools.
test_dcz.pyandtest_window_cap.pymove to the 30s reap budget;test_dcz.pygains the missingTimeoutExpiredguard (a slow exit propagated out of thefinallyand leaked the process), andtest_window_cap.pygains the missingwait()afterkill()(zombie until interpreter exit).Severity:
Low(test infrastructure — CI flake removal)Testing
py_compileon both tools; lint pre-pass over the diff (ruff/mypy/bandit/semgrep/ast-grep). The teardown shape now matches the seven tools #112 fixed. Includes a one-line RUF059 fix intest_dcz.py(body→_body) required by the pre-commit ruff gate on the touched file.