Update GitHub actions#24
Closed
danodonovan wants to merge 2 commits intomwilliamson:masterfrom
danodonovan:github-actions-updates
Closed
Update GitHub actions#24danodonovan wants to merge 2 commits intomwilliamson:masterfrom danodonovan:github-actions-updates
danodonovan wants to merge 2 commits intomwilliamson:masterfrom
danodonovan:github-actions-updates
Conversation
Closed
Owner
|
This has been fixed in master now, so closing this. Sorry for the duplicated effort: in general, I'd suggest making an issue and starting a discussion rather than making a pull request. |
Contributor
Author
|
coincidence 🤔 |
Owner
Sorry for not being clear: it was prompted by the issue you opened, so not a coincidence at all. As per the contributing guidelines that you linked to elsewhere, I recommend opening an issue and having a discussion before writing a pull request to avoid the duplicated effort, as has happened in this case, since I'll often prefer to make the changes myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The github action is outdated and failing.
Older pythons are no longer supported.
This PR updates the action so the tests can start building. It also adds a 'legacy' action to jury-rig builds for older less-supported pythons.
Once the CI is functional I believe other decisions on supporting or deprecating can be made, but these are difficult to reason about without a functional CI
CF #23