Skip to content

feat: Add webrtc-w3c protocol for browser to browser#309

Merged
MarcoPolo merged 2 commits into
multiformats:masterfrom
little-bear-labs:feat/webrtc-direct
Mar 3, 2023
Merged

feat: Add webrtc-w3c protocol for browser to browser#309
MarcoPolo merged 2 commits into
multiformats:masterfrom
little-bear-labs:feat/webrtc-direct

Conversation

@ckousik

@ckousik ckousik commented Feb 14, 2023

Copy link
Copy Markdown
Contributor

Adds a new protocol called webrtc-direct for enabling webrtc browser-to-browser. libp2p/specs#497

@mxinden

mxinden commented Feb 15, 2023

Copy link
Copy Markdown
Member

Great. Thanks for providing the patch. I suggest depending on your fork for now, i.e. not release this new multiaddr protocol component yet. That gives us still more time on libp2p/specs#497 (comment).

@ckousik ckousik changed the title feat: Add webrtc-direct protocol for browser to browser feat: Add webrtc-w3c protocol for browser to browser Mar 1, 2023
@p-shahi

p-shahi commented Mar 2, 2023

Copy link
Copy Markdown

Now that webrtc-w3c has been adopted per libp2p/specs#497 (comment) are we all clear for merging this PR? cc @mxinden

@mxinden mxinden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All clear to move forward here. I merged multiformats/multiaddr#150 and multiformats/multicodec#316.

@p-shahi

p-shahi commented Mar 3, 2023

Copy link
Copy Markdown

@achingbrain I think this requires an approval from a maintainer, would you be able to bless it

@MarcoPolo MarcoPolo merged commit 16232d5 into multiformats:master Mar 3, 2023
github-actions Bot pushed a commit that referenced this pull request Mar 3, 2023
## [11.5.0](v11.4.0...v11.5.0) (2023-03-03)

### Features

* Add webrtc-w3c protocol for browser to browser ([#309](#309)) ([16232d5](16232d5))
@github-actions

github-actions Bot commented Mar 3, 2023

Copy link
Copy Markdown

🎉 This PR is included in version 11.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

mxinden added a commit to mxinden/js-multiaddr that referenced this pull request Mar 9, 2023
We have decided to rename `webrtc-w3c` to `webrtc-private-to-private`. See
rational in multiformats/multiaddr#150.

No software has been released using `webrtc-w3c`, thus renaming is not a
breaking change. Ignoring the automated `multiaddr` `v11.5.0` release.

See also multiformats#309 that introduced `webrtc-w3c`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants