Validate bytes when parsing string#116
Conversation
|
Could you change the patch to call the (we should also document this) |
1 similar comment
|
Could you change the patch to call the (we should also document this) |
|
Okay, understood. Maybe it is better to call directly |
|
Maybe it is better to call directly `strings.Contains(s, "/")`?
SGTM.
Where should we document it?
Let's document the functions on the `Transcoder` interface.
|
66e4307 to
b00b4ac
Compare
|
Okay, done. I hope it is good enough, tell me if you want to change something. |
|
Thanks! |
Documented Transcoder functions, and fixed ip6zone string validation
If no validation is done, it can create invalid Multiaddr.
Probably there is an obvious reason for not doing it. So, if it is the case, I am sorry.
As an example, you can create an ip6zone Multiaddr from the following string:
ip6zone/. However, if you validate it, it raises an error, because it contains/