Skip to content

[CRUD] Refactor page titles to pageTitles and pageTitle props - #4930

Merged
apedroferreira merged 28 commits into
mui:masterfrom
apedroferreira:fix-themed-example-pagetitle
Jun 9, 2025
Merged

[CRUD] Refactor page titles to pageTitles and pageTitle props#4930
apedroferreira merged 28 commits into
mui:masterfrom
apedroferreira:fix-themed-example-pagetitle

Conversation

@apedroferreira

@apedroferreira apedroferreira commented May 6, 2025

Copy link
Copy Markdown
Collaborator

As discussed here the way that page titles integrate with CRUD needed improvements.

This PR fixes the issue with a new pageTitles prop, and by moving the PageContainer inside the Crud component.
Also added a pageContainer slot so that the page containers can be opted out of or modified.
CRUD pages now also take advantage of this to show the current page in the page breadcrumbs.

All necessary changes resulting from this have been added, and the examples can be found in 2 reverted commits in this PR to be merged after the next release.

Unrelated inclusion: also changes CRUD list view data grid so that actions column takes up less space if pinned

https://deploy-preview-4930--mui-toolpad-docs.netlify.app/toolpad/core/react-crud/#custom-page-titles
https://deploy-preview-4930--mui-toolpad-docs.netlify.app/toolpad/core/react-crud/#slots

@apedroferreira apedroferreira self-assigned this May 6, 2025
@apedroferreira apedroferreira added docs Improvements or additions to the documentation. examples Relating to /examples. labels May 6, 2025
@mui-bot

mui-bot commented May 6, 2025

Copy link
Copy Markdown

Netlify deploy preview

https://deploy-preview-4930--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against 7916d0d

@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 23, 2025
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 23, 2025
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 30, 2025
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label May 30, 2025
@apedroferreira apedroferreira moved this to In progress in Toolpad public roadmap May 30, 2025
@apedroferreira
apedroferreira marked this pull request as draft June 2, 2025 16:21
@apedroferreira apedroferreira changed the title Fix CRUD page titles in several examples [CRUD] Refactor page titles to pageTitles and pageTitle props Jun 4, 2025
@apedroferreira
apedroferreira removed the request for review from bharatkashyap June 4, 2025 14:57
@apedroferreira apedroferreira added component: crud and removed examples Relating to /examples. labels Jun 4, 2025
@apedroferreira
apedroferreira requested a review from a team June 4, 2025 15:01
@apedroferreira
apedroferreira marked this pull request as ready for review June 4, 2025 15:02
Comment thread docs/data/toolpad/core/components/crud/crud.md Outdated
Signed-off-by: Pedro Ferreira <10789765+apedroferreira@users.noreply.github.com>

@bharatkashyap bharatkashyap left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice enhancement 👍🏻

@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jun 9, 2025
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Jun 9, 2025
@apedroferreira
apedroferreira merged commit 1561ec6 into mui:master Jun 9, 2025
@github-project-automation github-project-automation Bot moved this from In progress to Done in Toolpad public roadmap Jun 9, 2025
@apedroferreira
apedroferreira deleted the fix-themed-example-pagetitle branch June 9, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants