Skip to content

Remove .js extensions from Next.js AppProvider imports - #4883

Closed
apedroferreira wants to merge 5 commits into
mui:masterfrom
apedroferreira:fix-turborepo-issue
Closed

Remove .js extensions from Next.js AppProvider imports#4883
apedroferreira wants to merge 5 commits into
mui:masterfrom
apedroferreira:fix-turborepo-issue

Conversation

@apedroferreira

@apedroferreira apedroferreira commented Apr 23, 2025

Copy link
Copy Markdown
Collaborator

Closes #4862 as it seems to fix it? Tried it in the repro: https://github.com/a88zach/issue-4862

Not sure exactly why it's happening though @Janpot

@apedroferreira apedroferreira added type: bug It doesn't behave as expected. scope: toolpad-core Abbreviated to "core" labels Apr 23, 2025
@apedroferreira apedroferreira self-assigned this Apr 23, 2025
@mui-bot

mui-bot commented Apr 23, 2025

Copy link
Copy Markdown

Netlify deploy preview

https://deploy-preview-4883--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against f00b8df

@apedroferreira
apedroferreira requested a review from Janpot April 23, 2025 23:26
@apedroferreira
apedroferreira marked this pull request as ready for review April 23, 2025 23:26

@Janpot Janpot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't do that because #4686 (comment)

I can't install https://github.com/a88zach/issue-4862 without errors, and it uses outdated versions of all our libraries. This reproduction should be scoped down, and the conflicting peer dependencies removed.

We could try the trick that we do in core

@a88zach

a88zach commented Apr 24, 2025

Copy link
Copy Markdown
Contributor

I can't install https://github.com/a88zach/issue-4862 without errors, and it uses outdated versions of all our libraries. This reproduction should be scoped down, and the conflicting peer dependencies removed.

You should be able to install using the --force flag as noted in the issue description and the readme.

This repo came directly from your examples using npx create-toolpad-app@latest --example auth-nextjs-themed

@apedroferreira
apedroferreira deleted the fix-turborepo-issue branch April 25, 2025 16:19
@apedroferreira

Copy link
Copy Markdown
Collaborator Author

As I've commented in #4862 (comment), the standard example with no changes seems not to have this issue, so it would be better to identify what exactly is causing the reloads on navigation before trying to find a solution.

I've closed this PR as we probably need more info on the problem to find a suitable solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: toolpad-core Abbreviated to "core" type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toolpad core does not work correctly with Turbopack

4 participants