Remove MUI X libraries as peer dependencies - #4854
Merged
Merged
Conversation
apedroferreira
added
internal
apedroferreira
marked this pull request as ready for review
April 16, 2025 16:39
Netlify deploy preview |
Janpot
approved these changes
Apr 16, 2025
Collaborator
|
Could this cause issues with people who have v7 X Packages installed in their project separately? Should we keep v7 as our dependency version till v8 is stable? |
Member
core v7 and x v7 are incompatible. so they shouldn't use x v7 with toolpad in the first place. if they don't want to use a beta version of x they shouldn't use toolpad. it's more unstable than a beta version of x. besides all of that. I don't see why two versions of the grid couldn't be together in one project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove MUI X libraries as peer dependencies, as it's not necessary for them to be.
Addresses Toolpad public roadmap (view)
Closes #4840