Skip to content

[CRUD] Expose subcomponent slots to top-level CRUD component - #4786

Merged
apedroferreira merged 3 commits into
mui:masterfrom
apedroferreira:top-level-crud-slots
Mar 24, 2025
Merged

[CRUD] Expose subcomponent slots to top-level CRUD component#4786
apedroferreira merged 3 commits into
mui:masterfrom
apedroferreira:top-level-crud-slots

Conversation

@apedroferreira

Copy link
Copy Markdown
Collaborator

So we can use a single Crud component in #4785

@apedroferreira apedroferreira added type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. scope: toolpad-core Abbreviated to "core" labels Mar 19, 2025
@apedroferreira apedroferreira self-assigned this Mar 19, 2025
@mui-bot

mui-bot commented Mar 19, 2025

Copy link
Copy Markdown

Netlify deploy preview

https://deploy-preview-4786--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against d40297c

@bharatkashyap bharatkashyap left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, but to be more future-looking, does it make more sense to shape the Crud slotss as list: ListSlots, create: CreateSlots ... and so on, given that we might need to do this in the future? But not to block, this is okay for me in its current form

@apedroferreira
apedroferreira merged commit 5874020 into mui:master Mar 24, 2025
@apedroferreira
apedroferreira deleted the top-level-crud-slots branch March 24, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: toolpad-core Abbreviated to "core" type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants