Skip to content

[CRUD] Add examples - #4713

Merged
apedroferreira merged 15 commits into
mui:masterfrom
apedroferreira:crud-examples
Mar 19, 2025
Merged

[CRUD] Add examples#4713
apedroferreira merged 15 commits into
mui:masterfrom
apedroferreira:crud-examples

Conversation

@apedroferreira

@apedroferreira apedroferreira commented Feb 28, 2025

Copy link
Copy Markdown
Collaborator

New examples with mock employees CRUD for Vite, Next.js App Router and Next.js Pages Router.

@apedroferreira apedroferreira added the docs Improvements or additions to the documentation. label Feb 28, 2025
@apedroferreira apedroferreira self-assigned this Feb 28, 2025
@mui-bot

mui-bot commented Feb 28, 2025

Copy link
Copy Markdown

Netlify deploy preview

https://deploy-preview-4713--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against 4acebfc

@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 5, 2025
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 7, 2025
@apedroferreira
apedroferreira requested a review from a team March 7, 2025 20:00
@apedroferreira
apedroferreira marked this pull request as ready for review March 7, 2025 20:00
@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 12, 2025
@prakhargupta1 prakhargupta1 moved this to In progress in Toolpad public roadmap Mar 12, 2025
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 12, 2025
@@ -0,0 +1,200 @@
'use client';

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to keep this example about authentication and next.js, and create a new example for data sources?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would if we're going for many small examples instead of just a few with multiple things.
As we already have quite a few examples this seems to be the approach we're following, so I guess 3 new examples would be okay, I'll change it.

@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 17, 2025

@Janpot Janpot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine 👍

@apedroferreira

Copy link
Copy Markdown
Collaborator Author

Seems fine 👍

Thanks, just missing some images for examples I think.

@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 18, 2025
@Janpot

Janpot commented Mar 18, 2025

Copy link
Copy Markdown
Member

Thanks, just missing some images for examples I think.

Yep, sry, I had just read over the "Files changed" tab, didn't notice CI failed

@apedroferreira

Copy link
Copy Markdown
Collaborator Author

Thanks, just missing some images for examples I think.

Yep, sry, I had just read over the "Files changed" tab, didn't notice CI failed

Should be ready now.

codeSandbox: true,
stackBlitz: true,
},
{

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should show them at the top of the list, for which you'd need to add them at the beginning just after the functional dashboard (since the component reverses this list when displaying the cards)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, just adjusted the order!

@apedroferreira
apedroferreira merged commit 8882dab into mui:master Mar 19, 2025
@github-project-automation github-project-automation Bot moved this from In progress to Completed in Toolpad public roadmap Mar 19, 2025
@apedroferreira
apedroferreira deleted the crud-examples branch March 19, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants